Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Reduces WebKit Playwright flakiness when opening the Diagnostics drawer, and tweaks the Workspaces toggle styling in the AI controls stylesheet.
Changes:
- Add a WebKit-friendly fallback (keyboard activation) when the Diagnostics toggle click is intercepted during transitions.
- Refactor Workspaces toggle hover/icon coloring to use a shared CSS custom property.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/styles/ai-controls.css | Introduces --workspaces-toggle-color and applies it to hover text and the Workspaces icon fill. |
| playwright/helpers/app-test-helpers.ts | Makes ensureDiagnosticsDrawerOpen() resilient to WebKit pointer-interception errors by falling back to keyboard activation and asserting aria-expanded. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.