[release-1.22] fix: write func.yaml before remote upload - #4023
Merged
knative-prow[bot] merged 1 commit intoAug 26, 2026
Conversation
Previously, func.yaml was only written to disk after deployment completed. For remote deploys, the pipeline uploads sources from disk to a PVC before the on-cluster deploy step runs. This meant CLI flags like --service-account or --deployer were not reflected in the uploaded func.yaml, so func-util defaulted an empty deployer to knative. Write func.yaml before the pipeline starts so the on-cluster deploy step sees the latest configuration. Backport of knative#3663. The 1.22 CLI has no --image-pull-secret, so the unit test covers --deployer instead.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
Bot
added
approved
gauron99
requested review from
lkingland and
matejvasek
and removed request for
dsimansk and
jrangelramos
August 25, 2026 20:02
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
persist the func.yaml before pipeline write because its the remote deployment works with the disk-version of func.yaml not the in-memory version. -- this is a workaround.
backporting this because of functions-operator which, because of this bug, cannot properly run e2e middleware update tests (deployer persistance does not work off-of knative)
Backport of #3663.
Changes
func.yamlbefore remote pipeline upload so deployer, service account, and other config persist on-cluster/kind bug
Relates to #3663
Release Note