[chrisnojima]

Summary

A failing test only, for review on its own: the pending (outbox) message activity goes out without an account id.

PostTextNonblock
  build MessagePlaintext            # ClientHeader.Sender not set yet
  NonblockingSender.Send
    outbox.PushMessage
      newMessageNotifier(obr)       # chat/deliverer.go
        uid := obr.Msg.ClientHeader.Sender    # empty
        ActivityNotifier.Activity(ctx, uid, ...)  -> NewChatActivity{uid: ""}

Since #29804 the app drops chat notifications that don't name the signed-in account. So on desktop it never shows a message as pending: no pending row, no sending indicator, and no deleting indicator on a message just sent. The outbox notification arrives (with the outbox ordinal), and is discarded.

TestChatSrvPendingMessageActivityNamesTheAccount posts through PostTextNonblock and asserts the outbox activity names the poster. The likely fix is one line in chat/deliverer.go: the outbox is per account (Deliverer.Start(ctx, uid)), so the notifier can use that uid instead of the record's header.

Evidence

Observed in the desktop app (renderer RPC log) for one send, uid as received:

NewChatActivity  outbox  ordinal 3896.1  outboxID d424…  uid ""
NewChatActivity  valid   messageID 3897  outboxID d424…  uid <account>

The new test compiles and is clean under go vet and golangci-lint --new-from-rev master. It needs kbweb (fake-user signup), which wasn't available where it was written, so it hasn't run locally: CI is where it fails.

Merge Danger

Door: two-way

Blast Radius: none

A test file only.