device clean#29261
Merged
chrisnojima merged 12 commits intoMay 29, 2026
Merged
Conversation
…heets, rename context
…ature, dedupe icon logic
Documents which style properties can be lifted into Box2 props (purely structural, no visual change) and how to use gap/gapStart/gapEnd to replace per-child margins (slight visual change — must be validated with user before applying). Also relaxes the hard-line no-visual-changes rule to allow validated visual changes with explicit user sign-off.
…ces/
- Extract box2ClassNames() from Box2 desktop branch into shared helper
- Export box2SharedProps from box.tsx
- ClickableBox3Props = Box2Props & {onClick?, onLongPress?, hitSlop?}
- CB3 desktop: box2ClassNames + clickable-box2 CSS class
- CB3 mobile: box2SharedProps + Pressable
- Migrate devices/ CB1/CB2 → CB3, eliminate inner Box2 wrappers
- Simplify mobileAddHeader style (flex/position props move to CB3 props)
- Add plans/clickablebox3.md migration plan with per-directory checklist
- Add/update migrate-clickable-box skill for CB3 migration
Replace fixed-height virtualized List with ScrollView so long TLF names that wrap to multiple lines don't overlap adjacent rows.
chrisnojima
merged commit 4a07f73
into
nojima/HOTPOT-next-670-clean-2
1 of 2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.