Telemetry categories: opt-in selection + lightweight default set#272
Open
Sayan- wants to merge 3 commits into
Open
Telemetry categories: opt-in selection + lightweight default set#272Sayan- wants to merge 3 commits into
Sayan- wants to merge 3 commits into
Conversation
Selection is now opt-in: a provided browser config captures exactly the categories set to enabled:true, and anything omitted is off (previously an omitted category defaulted to on). A request that enables nothing clears the configuration. The default set (used when no browser config is given) drops the CDP categories and screenshot, leaving the lightweight operational signals (control, connection, system, captcha). "Just turn it on" therefore never starts the CDP collector or emits high-volume streams; CDP and screenshots are opt-in. Reverts the opt-out fill from #268 (not yet consumed by anything). Co-authored-by: Cursor <cursoragent@cursor.com>
Pin the forward-compatibility guarantee that a newer control plane can send a telemetry category this image does not yet know: the strict handler decodes the body with encoding/json (no DisallowUnknownFields), so unknown categories are ignored, not rejected, and known categories still apply. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Created a monitoring plan for this PR. What this PR does: Changes browser telemetry to fully opt-in — the CDP categories (console, network, page, interaction) are removed from the default capture set so the CDP collector is never started unless explicitly requested. Intended effect:
Risks:
Status updates will be posted automatically on this PR as monitoring progresses. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
browserconfig captures exactly the categories set toenabled: true; anything omitted is off (previously omitted = on). A request that enables nothing clears telemetry.browserconfig given, e.g.enabled: true) is now the lightweight operational signals:control, connection, system, captcha. The CDP categories (console, network, page, interaction) andscreenshotare dropped from the default and must be opted into.Why
"Just turn it on" should not spin up the CDP collector or unleash the high-volume streams. With this default, the collector only starts when a CDP category is explicitly enabled, and
monitor(collector health) rides along only then. This is the firehose-safe default.Test plan
Note
Cursor Bugbot is generating a summary for commit 71d3c04. Configure here.