-
Notifications
You must be signed in to change notification settings - Fork 67
feat: add WebRTC live streaming option as alternative to noVNC #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
10d13b8
feat: add WebRTC live streaming option as alternative to noVNC
xonkernel e32a2ab
docs: add explanation for /dev/shm mounting logic
xonkernel b535810
chore: add comment for neko.yaml and remove some unused config variables
xonkernel f7ab09c
chore: update Node image to latest LTS (v22)
xonkernel e076d96
chore: remove sleeps in bootstrap scripts
xonkernel 55b5566
chore: move xclip installation alongside other neko-related dependenc…
xonkernel a09aac7
chore(config): enable implicit_hosting to auto-unlock screen control
xonkernel b83bbdd
chore(config): move some env var config to YAML file
xonkernel 449f22c
feat(ui): hide video overlay icons
xonkernel 661781e
docker run instructions and consistently exposing vnc or neko on main…
rgarcia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| "presets": ["@vue/cli-plugin-babel/preset"] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| > 1% | ||
| last 2 versions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| root = true | ||
|
|
||
| [*] | ||
| charset = utf-8 | ||
| indent_style = space | ||
| indent_size = 2 | ||
| end_of_line = lf | ||
| insert_final_newline = true | ||
| trim_trailing_whitespace = true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| { | ||
| "root": true, | ||
| "env": { | ||
| "node": true | ||
| }, | ||
| "extends": ["plugin:vue/essential", "@vue/prettier", "@vue/typescript"], | ||
| "parserOptions": { | ||
| "parser": "@typescript-eslint/parser" | ||
| }, | ||
| "rules": { | ||
| "vue/valid-v-for": "off", | ||
| "no-case-declarations": "off", | ||
| "no-dupe-class-members": "off", | ||
| "no-console": "off", | ||
| "no-empty": "off" | ||
| } | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { | ||
| "semi": false, | ||
| "trailingComma": "all", | ||
| "singleQuote": true, | ||
| "printWidth": 120, | ||
| "tabWidth": 2, | ||
| "vueIndentScriptAndStyle": true | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| { | ||
| "editor.tabSize": 2, | ||
| "editor.insertSpaces": true, | ||
| "editor.detectIndentation": false, | ||
| "files.encoding": "utf8", | ||
| "files.eol": "\n", | ||
| "typescript.tsdk": "./node_modules/typescript/lib", | ||
| "todo-tree.filtering.excludeGlobs": ["**/node_modules/**"], | ||
| "eslint.validate": [ | ||
| "vue", | ||
| "javascript", | ||
| "javascriptreact", | ||
| "typescript", | ||
| "typescriptreact", | ||
| ], | ||
| "vetur.validation.template": true, | ||
| "vetur.useWorkspaceDependencies": true, | ||
| "remote.extensionKind": { | ||
| "ms-azuretools.vscode-docker": "ui" | ||
| }, | ||
| "editor.formatOnSave": false, | ||
| "editor.codeActionsOnSave": { | ||
| "source.fixAll.eslint": true | ||
| }, | ||
| "remote.containers.defaultExtensions": [ | ||
| "octref.vetur", | ||
| "esbenp.prettier-vscode", | ||
| "dbaeumer.vscode-eslint", | ||
| "ms-vscode-remote.vscode-remote-extensionpack", | ||
| "ms-vscode-remote.remote-containers", | ||
| "ms-azuretools.vscode-docker", | ||
| "editorconfig.editorconfig", | ||
| "gruntfuggly.todo-tree", | ||
| "eamodio.gitlens", | ||
| "swyphcosmo.spellchecker" | ||
| ], | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| ARG BASE_IMAGE=node:18-bullseye-slim | ||
| FROM $BASE_IMAGE AS client | ||
|
|
||
| WORKDIR /src | ||
|
|
||
| # | ||
| # install dependencies | ||
| COPY package*.json ./ | ||
| RUN npm install | ||
|
|
||
| # | ||
| # build client | ||
| COPY . . | ||
| RUN npm run build | ||
|
|
||
| # | ||
| # artifacts from this stage | ||
| # COPY --from=client /src/dist/ /var/www |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| #!/bin/sh | ||
| cd "$(dirname "$0")" | ||
|
|
||
| # start component watch | ||
| docker run --rm -it \ | ||
| --user "$(id -u):$(id -g)" \ | ||
| --volume "${PWD}/../:/app" \ | ||
| --entrypoint="npm" \ | ||
| --workdir="/app" \ | ||
| node:18-bullseye-slim run build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| #!/bin/sh | ||
| cd "$(dirname "$0")" | ||
|
|
||
| # start component watch | ||
| docker run --rm -it \ | ||
| --user "$(id -u):$(id -g)" \ | ||
| --volume "${PWD}/../:/app" \ | ||
| --entrypoint="/bin/bash" \ | ||
| --workdir="/app" \ | ||
| node:18-bullseye-slim |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| #!/bin/sh | ||
| cd "$(dirname "$0")" | ||
|
|
||
| # npm | ||
| docker run --rm -it \ | ||
| --user "$(id -u):$(id -g)" \ | ||
| --volume "${PWD}/../:/app" \ | ||
| --entrypoint="npm" \ | ||
| --workdir="/app" \ | ||
| node:18-bullseye-slim "$@" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| #!/bin/bash | ||
| cd "$(dirname "$0")" | ||
|
|
||
| if [ -z $VUE_APP_SERVER_PORT ]; then | ||
| VUE_APP_SERVER_PORT="3000" | ||
| fi | ||
|
|
||
| echo "Using VUE_APP_SERVER_PORT: ${VUE_APP_SERVER_PORT}" | ||
|
|
||
| # use -i to install | ||
| if [ ! -d "${PWD}/../node_modules" ] || [ "$1" == "-i" ]; then | ||
| docker run --rm -it \ | ||
| --volume "${PWD}/../:/app" \ | ||
| --workdir="/app" \ | ||
| --entrypoint="npm" \ | ||
| node:18-bullseye-slim install | ||
| fi | ||
|
|
||
| # npm run serve | ||
| docker run --rm -it \ | ||
| -p 3001:3001 \ | ||
| -e "VUE_APP_SERVER_PORT=$VUE_APP_SERVER_PORT" \ | ||
| --user "$(id -u):$(id -g)" \ | ||
| --volume "${PWD}/../:/app" \ | ||
| --entrypoint="npm" \ | ||
| --workdir="/app" \ | ||
| node:18-bullseye-slim run serve -- --port 3001 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
going through and testing this all and noticed that
containers/docker/README.mdprobably needs an update too?