allow customizing chromium flags#11
Merged
rgarcia merged 3 commits intoJun 4, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables customizable Chromium startup flags via an environment variable, splits the unikernel workflow into separate build and run scripts, and updates documentation accordingly.
- Replace hard-coded Chromium flags with the
CHROMIUM_FLAGSvariable in both the unikernel wrapper and Dockerfile - Add
build.shandrun.sh, and remove the olddeploy.sh, to separate build and run steps - Update README files and introduce
start-buildkit.shto streamline the build environment setup
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| unikernels/unikraft-cu/wrapper.sh | Use CHROMIUM_FLAGS env in place of hard-coded Chromium flags |
| unikernels/unikraft-cu/build.sh | New script for packaging and pushing the unikernel image |
| unikernels/unikraft-cu/run.sh | New script to launch the unikernel instance with custom flags |
| unikernels/unikraft-cu/deploy.sh | Removed legacy deploy script |
| unikernels/unikraft-cu/README.md | Updated steps: build then run instead of deploy |
| shared/start-buildkit.sh | New helper to install/start BuildKit container |
| containers/docker/README.md | Document passing CHROMIUM_FLAGS when running the Docker image |
| containers/docker/Dockerfile | Use CHROMIUM_FLAGS env for Chromium startup flags |
Comments suppressed due to low confidence (1)
unikernels/unikraft-cu/run.sh:7
- The
--startline is missing a trailing backslash (\) for proper line continuation; add it to ensure the-M 8192argument is passed tokraft cloud inst create.
--start
|
|
||
| test "$(docker container inspect -f '{{.State.Running}}' buildkit 2> /dev/null)" = "true" | ||
| if test $? -eq 0; then | ||
| echo "Container 'buidlkitd' is already running. Nothing to do." |
There was a problem hiding this comment.
Typo in the container name: 'buidlkitd' should be 'buildkit'.
Suggested change
| echo "Container 'buidlkitd' is already running. Nothing to do." | |
| echo "Container 'buildkit' is already running. Nothing to do." |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
mertcelebi
approved these changes
Jun 4, 2025
rgarcia
deleted the
raf/kernel-33-configurable-browsers-residential-proxies-captcha-byo
branch
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also splitting up build and run for the unikernel stuff (similar to docker)