fix(node-dependency-matrix): count gRPC test cases in recording calibration (0 → 2)#103
Merged
Shivanipandey31 merged 1 commit intoJul 2, 2026
Conversation
…ration k8s-proxy now records gRPC test cases in the recording session (previously dropped because processTestCase only counted entries with a non-empty HTTPReq.URL). The two calls in send_grpc_traffic.sh (Ping, RunDependencyScenario) each declare expectedAdditionalTestcases: 1, so the aggregate must reflect them. Bump grpcTrafficScript.expectedAdditionalTestcasesExact 0 -> 2 so getExpectedTotalTestcases() settles at 19 (HTTP) + 2 (gRPC) = 21, matching the recorded total once k8s-proxy counts gRPC cases. The kube-regression assertion is a <= ceiling, so this stays backward-compatible with released k8s-proxy (records 19; 19 <= 21). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Problem
The kube-regression suite (enterprise-ui,
kube-flow.spec.tstest 8) asserts that the number of recorded test cases stays at or below a calibrated total read from this sample'sfixtures/expected-values.json:expectedAdditionalTestcasesExactwas pinned at0because, at calibration time, k8s-proxy silently dropped gRPC test cases from the recording session —processTestCaseonly counted entries with a non-emptyHTTPReq.URL, so the two gRPC calls insend_grpc_traffic.shnever incremented the recorded total. Observed gRPC contribution was genuinely 0.k8s-proxy PR #542 now records gRPC test cases (recognizes
GRPC_EXPORT, populates the endpoint list, incrementsTestsRecorded). With that change the recording produces 21 test cases (19 HTTP + 2 gRPC), tripping the assertion:Fix
Bump
grpcTrafficScript.expectedAdditionalTestcasesExactfrom0 → 2, so the calibrated total becomes19 + 2 = 21and matches the recorded reality once gRPC cases are counted.This just reconciles the aggregate with the per-call values already declared in the same file — both gRPC calls (
Ping,RunDependencyScenario) already carryexpectedAdditionalTestcases: 1.🔄 Change
node-dependency-matrix/fixtures/expected-values.json:expectedAdditionalTestcasesExact0 → 2(1 line)✅ Compatibility
The kube-regression assertion is a
<=ceiling, so raising it is backward-compatible:19 <= 21✅21 <= 21✅No ordering dependency with PR #542 — this can merge before or after it without breaking any consumer.
🧪 Testing
Validated against k8s-proxy PR #542's
playwright-kube-regressionpipeline by temporarily pointingSAMPLES_TYPESCRIPT_REFat this change. Test 8 went green withTest cases=21and the full record → auto-replay flow completed:Related: keploy/k8s-proxy#542