#64 #65 #66: the tab knows the database it holds - #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Getting a database open can take real work: signing in to Google, or finding the USB stick it lives on. Today a tab gives none of that back — several tabs all read "KeePass Web", so the only way to find the right one is to open each; a stray back button or a mistimed click on the file navigator throws the session away without a word, since nothing is asked unless there are unsaved edits; and an open database stays decrypted for as long as the tab sits there, however long its owner has been away.
In this PR the tab carries the file's name and a lock icon, so the right one is obvious from the tab bar. Leaving a database, by the back button or the file navigator, asks first whether or not anything is unsaved, and the question stays cheap when nothing would actually be lost. A tab left hidden locks itself after a delay the settings dialog now offers; that costs no edits, because locking keeps them.