Pull down, don't release, then pull down more - it constantly refreshes

[niftylettuce]

This is a bug, e.g. you pull down a bit, then don't release, then pull down more, it will refresh again and again as you pull down more and more.

[atom2ueki]

@niftylettuce

handleScroll(e) {
    var scrollY = e.nativeEvent.contentInset.top + e.nativeEvent.contentOffset.y
    this.lastScrollY = scrollY
    this.lastContentInsetTop = e.nativeEvent.contentInset.top
    this.lastContentOffsetX = e.nativeEvent.contentOffset.x

    if (this.isTouching || (!this.isTouching && !this.props.ignoreInertialScroll)) {
      if (scrollY < -this.props.minPulldownDistance) {
        if (!this.props.isRefreshing) {
          if (this.props.onRefresh) {
            this.props.onRefresh()
          }
        }
      }
    }

    this.props.onScroll && this.props.onScroll(e)
  },

the logic is trigger refresh base on distance only currently, and when the time we still touching screen, refresh triggered, however scrollY does not reset, that's why it triggered again & again, but I can said that people more suitable on checking release touch & min distance to trigger the refresh, and also need reset scrollY after every refresh

[jsdf]

This should be fixed on master now. 

—

Cheers,

James

On Tue, Nov 24, 2015 at 5:04 PM, Tony Li notifications@github.com wrote:

@niftylettuce

handleScroll(e) {
    var scrollY = e.nativeEvent.contentInset.top + e.nativeEvent.contentOffset.y
    this.lastScrollY = scrollY
    this.lastContentInsetTop = e.nativeEvent.contentInset.top
    this.lastContentOffsetX = e.nativeEvent.contentOffset.x
    if (this.isTouching || (!this.isTouching && !this.props.ignoreInertialScroll)) {
      if (scrollY < -this.props.minPulldownDistance) {
        if (!this.props.isRefreshing) {
          if (this.props.onRefresh) {
            this.props.onRefresh()
          }
        }
      }
    }
    this.props.onScroll && this.props.onScroll(e)
  },

the logic is trigger refresh base on distance only currently, and when the time we still touching screen, refresh triggered, however scrollY does not reset, that's why it triggered again & again, but I can said that people more suitable on checking release touch & min distance to trigger the refresh, and also need reset scrollY after every refresh

Reply to this email directly or view it on GitHub:
#32 (comment)

[niftylettuce]

@jsdf it's not. I can still pull down continously and get the spinner/refresh. please fix.

[niftylettuce]

I am using master in my package.json FYI -- so this is definitely a bug still

[manask88]

@jsdf , any news on when this can be fixed?

[jsdf]

I haven't time to work on it. I work on this project in my own time, and I haven't had much of that to spare lately. I'd happily accept a PR to fix it, however.

[natorojr]

This may be a duplicate of #16.

@jsdf Seems like you have several open PRs fixing essentially the same issue.