Skip to content

fix reading of OCCIBLOB #160

Merged
johannish merged 1 commit into
joeferner:masterfrom
burkostya:master
Sep 17, 2014
Merged

fix reading of OCCIBLOB #160
johannish merged 1 commit into
joeferner:masterfrom
burkostya:master

Conversation

@burkostya

Copy link
Copy Markdown

We do not need these deletes because node::Buffer::New accepts RandomBytesFree callback for deleting buffer by GC. fixes #92

We do not need these deletes because `node::Buffer::New` accepts `RandomBytesFree` callback for deleting `buffer` by GC. fixes joeferner#92
@burkostya

Copy link
Copy Markdown
Author

Another approach will be using node::Buffer::New(buffer, bufferLength). This constructor will create copy of buffer.

@realityfilter

Copy link
Copy Markdown

Thanks for this fix. This should be merged soon. Otherwise users may get wrong blob results of correct size without getting an error.

@flyth

flyth commented Sep 17, 2014

Copy link
Copy Markdown
Contributor

Yes, please merge this - the problem has actually been fixed before at miktam@ddef503 / #42 but got back in with b22b009 .

johannish added a commit that referenced this pull request Sep 17, 2014
@johannish
johannish merged commit c1864a0 into joeferner:master Sep 17, 2014
@johannish

Copy link
Copy Markdown
Collaborator

@realityfilter @flyth @burkostya Please try this again from the current master and confirm that your issue is resolved. I'd like to have some feedback before we push to npm.

@realityfilter

Copy link
Copy Markdown

See my comment on #160. Only after applying this patch I was able to export CLOB data. I compared hashes and successfully exported some GB of data with it.

@burkostya

Copy link
Copy Markdown
Author

@raztus Can confirm. Reading from db using master works correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OCCIBLOB extraction

4 participants