FIX only warn about libomp/libiomp conflict on Linux#222
Merged
ogrisel merged 2 commits intoJul 10, 2026
Conversation
The incompatibility between Intel and LLVM OpenMP runtimes is documented as a Linux-specific issue. Emitting the warning on Windows caused CI failures in the conda-forge MKL job because pytest runs with -W error. Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Contributor
Author
|
Maybe we should also check that the libiomp + libomp crash on linux is still happening with the latest versions of those libraries. It could be the case that they have become more compatible overtime and that raising a warning is no longer needed on any platform. |
ogrisel
commented
Jul 10, 2026
Contributor
Author
|
Let's merge this to get a clean CI ASAP and I will follow-up with more testing to check if warning on Linux is still needed or not. |
itamarst
approved these changes
Jul 10, 2026
itamarst
left a comment
itamarst
left a comment
Contributor
There was a problem hiding this comment.
Insofar as I can review things: this seems reasonable to me.
Contributor
Author
|
For the record, we can still reproduce the crash on linux using the reproducers in ogrisel#14. So let's keep the warning on linux. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tentative fix Windows
pylatest_conda_forge_mklCI failure.The conda-forge MKL environment loads both
libiompandlibomp, triggeringRuntimeWarningon everyThreadpoolControllerinit. pytest runs with-W error, so tests fail.The incompatibility between Intel and LLVM OpenMP runtimes is documented as a Linux-specific issue. This change skips the warning on non-Linux platforms.
Note: I am not sure if this is the right fix, but it's interesting to check if the crash is indeed Linux specific or not.
The alternative would be to change the dependencies in the CI config so that the Windows CI jobs that need MKL would not load clang's OpenMP runtime.