Fix: Decode auth header, to not encode it as b'...' in the HTTP request#11
Closed
devurandom wants to merge 1 commit intojgarzik:masterfrom
Closed
Fix: Decode auth header, to not encode it as b'...' in the HTTP request#11devurandom wants to merge 1 commit intojgarzik:masterfrom
devurandom wants to merge 1 commit intojgarzik:masterfrom
Conversation
Contributor
|
This should definitely be included. Works in Python 2 and 3. |
Contributor
|
Since the header needs to be encoded eventually, the original method stored the header as bytes rather than a string. This regression came from 2736b3d. It might be ideal to just do the same as it used to do, in case for any reason someone needs to use a non-UTF8 user/pass. |
Contributor
|
Oh, sorry! I thought the |
Contributor
|
#23 also fixes this in a more compatible way. |
Owner
|
Closed, obsolete |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the authpair is encoded as b'...' within the HTTP request, which is obviously wrong. This commit fixes it.