Skip to content

Fix/fix typo in readme#27

Merged
jglick merged 2 commits intojenkinsci:masterfrom
metters:fix/Fix-typo-in-README
Sep 16, 2022
Merged

Fix/fix typo in readme#27
jglick merged 2 commits intojenkinsci:masterfrom
metters:fix/Fix-typo-in-README

Conversation

@metters
Copy link
Copy Markdown
Contributor

@metters metters commented Jan 28, 2022

  1. I fixed some minor typos in the README-file, especially Vershion, which should be Version.
  2. My IntelliJ IDEA also added two *.iml files which i added to the gitignore file. I can also remove that if you mind that change.
  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira // --> No issue exists
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue // It is the README, no tests

@metters
Copy link
Copy Markdown
Contributor Author

metters commented Jan 28, 2022

TBH, I was not sure about the TODO: Link to relevant pull requests, esp. upstream and downstream changes.
This is the PR and the changes are here. If there is something missing please let me know, I will provide it.

The changes are so minor, however, I doubt it is necessary.
Have a nice weekend.

@jglick jglick merged commit 7087332 into jenkinsci:master Sep 16, 2022
@metters metters deleted the fix/Fix-typo-in-README branch September 17, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants