docs: fix values for RUNTIME.osType and RUNTIME.archType. Simplify examples#8785
docs: fix values for RUNTIME.osType and RUNTIME.archType. Simplify examples#8785
Conversation
Greptile SummaryThis PR corrects Confidence Score: 5/5Safe to merge — documentation-only corrections that align with the actual runtime values. All changes are documentation fixes verified against the Rust source in crates/vfox/src/config.rs. The os() function returns lowercase values ("darwin", "linux", "windows") and arch() returns "amd64"/"arm64"/as-is, exactly matching what the docs now say. No logic, tests, or production code are modified. The previously flagged inconsistency between the two docs files is resolved in this PR. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[RUNTIME.osType] -->|"== 'windows'"| B["'win' (get_os)\n'zip' extension\nWindows paths"]
A -->|other| C["RUNTIME.osType as-is\n('linux', 'darwin', ...)"]
D[RUNTIME.archType] -->|"== 'amd64'"| E["'x64'"]
D -->|other| F["RUNTIME.archType as-is\n('arm64', 'x86', ...)"]
Reviews (5): Last reviewed commit: "apply gemini-code-assist suggestions" | Re-trigger Greptile |
There was a problem hiding this comment.
Code Review
This pull request updates the documentation and example code to use lowercase values for RUNTIME.osType and RUNTIME.archType, ensuring consistency with the runtime's behavior. It also simplifies several architecture and OS mapping functions by removing redundant conditional branches. The review feedback suggests further refining these examples by using Lua's and/or idiom for more concise conditional assignments and return statements.
8661b65 to
e3df5fe
Compare
examples Signed-off-by: Esteve Fernandez <esteve@apache.org>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Signed-off-by: Esteve Fernandez <esteve@apache.org>
530fc52 to
aa3291e
Compare
### 🚀 Features - **(exec)** add process sandboxing for mise x and mise run by @jdx in [#8845](#8845) ### 📚 Documentation - fix values for RUNTIME.osType and RUNTIME.archType. Simplify examples by @esteve in [#8785](#8785) ### 📦️ Dependency Updates - update ghcr.io/jdx/mise:copr docker digest to 6dd31ee by @renovate[bot] in [#8860](#8860) - update ghcr.io/jdx/mise:alpine docker digest to 4b8b285 by @renovate[bot] in [#8859](#8859) - update ghcr.io/jdx/mise:deb docker digest to 56ddc49 by @renovate[bot] in [#8861](#8861) - update ghcr.io/jdx/mise:rpm docker digest to b37cc3b by @renovate[bot] in [#8862](#8862) ### New Contributors - @esteve made their first contribution in [#8785](#8785)
This is a continuation of #6732, some of the documentation still was inconsistent with the code. I've also simplified some of the examples.