fix(node): expand tilde in default_packages_file path

[jdx]

Summary

• Wrap settings.node.default_packages_file() with file::replace_path() to expand ~ to $HOME, matching the behavior of Ruby, Go, and Python plugins.

Closes #8606

Test plan

• Set default_packages_file = "~/.config/mise/default-npm-packages" in ~/.config/mise/config.toml
• Run mise install node and verify default packages are installed

🤖 Generated with Claude Code

---

Note

Low Risk
Low risk: a small path-resolution change limited to reading the Node default-packages list, with behavior now consistent with other plugins.

Overview
Fixes Node default npm package installation when settings.node.default_packages_file uses ~ by expanding the path via file::replace_path() before reading the file.

^{Written by Cursor Bugbot for commit c797d14. This will update automatically on new commits. Configure here.}

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an inconsistency in path handling within the Node.js plugin. By introducing tilde expansion for the default_packages_file setting, it resolves an issue where user-defined paths starting with ~ were not correctly interpreted, thereby improving the reliability and user experience when configuring default Node.js packages.

Highlights

• Path Resolution: Implemented tilde (~) expansion for the default_packages_file path in the Node.js plugin, ensuring consistency with other language plugins like Ruby, Go, and Python.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[greptile-apps]

Greptile Summary

This PR fixes a one-line bug in the Node plugin where a user-configured default_packages_file path containing ~ was not expanded to $HOME, causing the file to not be found and default packages to be silently skipped. The fix wraps the result of settings.node.default_packages_file() with file::replace_path(), which is exactly the same pattern already used in the Ruby (ruby.rs, ruby_windows.rs) and Go (go.rs) plugins.

Key observations:

• The fix is minimal and targeted — one line changed.
• The default fallback paths (e.g. ~/.default-nodejs-packages) are already returned as absolute PathBuf values via env::HOME.join(...), so passing them through file::replace_path() is a no-op and introduces no regression.
• Paths from the NODE_DEFAULT_PACKAGES_FILE env var are constructed with PathBuf::from(), which does not expand ~; this fix correctly handles that case too.
• The existing e2e test (e2e/core/test_node_slow) uses an absolute $PWD-based path, so it does not exercise the tilde expansion — but the change is simple enough that a manual test (as described in the PR) is sufficient.

Confidence Score: 5/5

• Safe to merge — minimal, correct, well-precedented one-line fix with no regression risk.
• The change is a single-line addition that mirrors an identical pattern already used in Ruby and Go plugins. The default fallback paths are unaffected (they are already absolute), and the only behavioral change is the intended one: expanding ~ in user-configured paths. No new dependencies, no logic changes, no risk of data loss.
• No files require special attention.

Important Files Changed

Filename	Overview
src/plugins/core/node.rs	Single-line fix wrapping settings.node.default_packages_file() with file::replace_path() to expand ~ in user-specified paths, consistent with Ruby and Go plugins.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["install_default_packages()"] --> B["settings.node.default_packages_file()"]
    B --> C{Source}
    C -->|"config.toml setting"| D["User-defined path\n(may contain ~)"]
    C -->|"NODE_DEFAULT_PACKAGES_FILE env var"| E["Env var path\n(may contain ~)"]
    C -->|"fallback"| F["~/.default-nodejs-packages\n~/.default-node-packages\n~/.default-npm-packages\n(already absolute via HOME.join)"]
    D --> G["file::replace_path()\n~ → $HOME"]
    E --> G
    F --> G
    G --> H["file::read_to_string()\nnpm install --global"]

Loading

_{Reviews (2): Last reviewed commit: "[autofix.ci] apply automated fixes" | Re-trigger Greptile}

[gemini-code-assist]

Code Review

This pull request correctly identifies the need to expand tilde in the default_packages_file path for the node plugin, making it consistent with other plugins. However, the file::replace_path function being used has a bug related to tilde expansion where it does not handle ~ by itself. I've left a comment with details on the issue and a suggested fix. I have updated the suggested fix to use dirs::home_dir().unwrap() instead of dirs::HOME.clone() as dirs::HOME is an Option and this avoids a potential panic.

[gemini-code-assist]

The file::replace_path function doesn't correctly handle a path that is exactly ~. It only expands paths starting with ~/. If a user configures default_packages_file = "~", this will cause read_to_string to look for a file named ~ in the current directory, which is incorrect.

While file::replace_path is not in this diff, it should be fixed to be more robust. A correct implementation should also handle the ~ case. For example:

pub fn replace_path<P: AsRef<Path>>(path: P) -> PathBuf {
    let s = path.as_ref().to_string_lossy();
    if s == "~" {
        dirs::home_dir().unwrap()
    } else if let Some(p) = s.strip_prefix("~/") {
        dirs::home_dir().unwrap().join(p)
    } else {
        path.as_ref().to_path_buf()
    }
}

[github-actions]

Hyperfine Performance

mise x -- echo

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
mise-2026.3.10 x -- echo	25.5 ± 0.7	23.8	29.6	1.00 ± 0.04
mise x -- echo	25.4 ± 0.8	23.9	36.2	1.00

mise env

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
mise-2026.3.10 env	24.9 ± 0.9	23.0	29.6	1.01 ± 0.04
mise env	24.8 ± 0.6	23.4	26.8	1.00

mise hook-env

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
mise-2026.3.10 hook-env	24.6 ± 0.5	23.7	26.5	1.00
mise hook-env	24.9 ± 0.5	23.9	27.0	1.01 ± 0.03

mise ls

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
mise-2026.3.10 ls	23.6 ± 0.4	22.9	25.5	1.00
mise ls	24.2 ± 0.7	23.1	29.5	1.02 ± 0.04

xtasks/test/perf

Command	mise-2026.3.10	mise	Variance
install (cached)	153ms	152ms	+0%
ls (cached)	84ms	84ms	+0%
bin-paths (cached)	87ms	87ms	+0%
task-ls (cached)	849ms	⚠️ 4692ms	-81%

⚠️ Warning: task-ls cached performance variance is -81%