Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request expands the available coding agents by integrating the Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds the pi coding agent to the mise registry. The configuration specifies both a GitHub and an npm backend. However, the default GitHub backend is configured incorrectly, as it will install a binary named pi-mono while the test command expects pi. I've suggested a fix to rename the binary upon installation.
| @@ -0,0 +1,3 @@ | |||
| backends = ["github:badlogic/pi-mono", "npm:@mariozechner/pi-coding-agent"] | |||
There was a problem hiding this comment.
The github:badlogic/pi-mono backend provides a binary named pi-mono (e.g., pi-mono-linux-amd64), but the test command expects pi. This will cause the test to fail when using the GitHub backend, which is the default. You should use the exe option to rename the binary to pi upon installation.
| backends = ["github:badlogic/pi-mono", "npm:@mariozechner/pi-coding-agent"] | |
| backends = [{ full = "github:badlogic/pi-mono", options = { exe = "pi" } }, "npm:@mariozechner/pi-coding-agent"] |
Greptile SummaryThis PR adds a registry entry for pi, a minimal terminal coding agent CLI distributed as
Confidence Score: 3/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[mise install pi] --> B{Try backends in order}
B --> C[github backend - badlogic/pi-mono]
C --> D{Binary release assets exist?}
D -- Yes --> E[Install binary - success]
D -- No --> F[Backend fails]
F --> G[npm backend - mariozechner/pi-coding-agent]
G --> H[npm global install - success]
Last reviewed commit: 5285a37 |
| @@ -0,0 +1,3 @@ | |||
| backends = ["github:badlogic/pi-mono", "npm:@mariozechner/pi-coding-agent"] | |||
There was a problem hiding this comment.
github: backend likely non-functional for this TypeScript npm package
badlogic/pi-mono is a TypeScript monorepo whose distribution method is npm install -g @mariozechner/pi-coding-agent. The github: backend in mise attempts to download pre-compiled binary release assets from GitHub Releases. Since pi-mono does not appear to publish standalone binary artifacts in its GitHub releases (only npm version tags like v0.59.0), the github:badlogic/pi-mono backend will fail at install time for users who rely on it.
The canonical install path for other npm-distributed coding agents in this registry (e.g. amp.toml, codex.toml) is either npm: alone or aqua: + npm: (when an aqua manifest exists). If pi-mono does ship platform binaries as GitHub release assets this is fine — but if not, the entry should be:
| backends = ["github:badlogic/pi-mono", "npm:@mariozechner/pi-coding-agent"] | |
| backends = ["npm:@mariozechner/pi-coding-agent"] |
There was a problem hiding this comment.
--version runs but prompting is broken in the latest version. Checking 👀
risu729
left a comment
There was a problem hiding this comment.
Monorepo but 25.6k stars. https://github.com/badlogic/pi-mono
### 🐛 Bug Fixes - **(config)** resolve trust hash collision for same-name directories by @tdragon in [#8628](#8628) - **(docs)** fix width of tools table by @himkt in [#8625](#8625) - **(docs)** prevent homepage hero atmosphere overflow by @nygmaaa in [#8642](#8642) - **(doctor)** detect PATH ordering issues when mise is activated by @jdx in [#8585](#8585) - **(git)** use origin as remote name by @bentinata in [#8626](#8626) - **(installer)** normalize current version before comparison by @tak848 in [#8649](#8649) - **(lockfile)** Resolve symlink when updating lockfiles by @chancez in [#8589](#8589) - **(python)** verify checksums for precompiled binary downloads by @malept in [#8593](#8593) - **(rust)** resolve relative CARGO_HOME/RUSTUP_HOME to absolute paths by @simonepri in [#8604](#8604) - **(task)** correctly resolve task name for _default files with extensions by @youta1119 in [#8646](#8646) - **(tasks)** global file tasks not properly marked as such by @roele in [#8618](#8618) - **(tasks)** handle broken pipe in table print and task completion output by @vmaleze in [#8608](#8608) - use dark/light logo variants in README for GitHub dark mode by @jdx in [#8656](#8656) - failing rebuild of runtime symlinks for shared tools by @roele in [#8647](#8647) - add spaces around current element operator in flutter version_expr by @roele in [#8616](#8616) - complete task arguments correctly by @KevSlashNull in [#8601](#8601) ### 📚 Documentation - switch body font to DM Sans and darken dark mode background by @jdx in [6e3ad34](6e3ad34) - use Cormorant Garamond for headers and Roc Grotesk for body text by @jdx in [010812a](010812a) - resolve chaotic heading hierarchy in task-arguments.md by @muzimuzhi in [#8644](#8644) ### 🧪 Testing - fix test_java and mark as slow by @roele in [#8634](#8634) ### 📦️ Dependency Updates - update docker/dockerfile:1 docker digest to 4a43a54 by @renovate[bot] in [#8657](#8657) - update ghcr.io/jdx/mise:alpine docker digest to 2584470 by @renovate[bot] in [#8658](#8658) ### 📦 Registry - add viteplus (npm:vite-plus) by @risu729 in [#8594](#8594) - remove backend.options for podman by @roele in [#8633](#8633) - add pi.dev coding agent by @dector in [#8635](#8635) - add ormolu ([github:tweag/ormolu](https://github.com/tweag/ormolu)) by @3w36zj6 in [#8617](#8617) - use version_expr for dart and sort versions by @roele in [#8631](#8631) ### New Contributors - @bentinata made their first contribution in [#8626](#8626) - @tdragon made their first contribution in [#8628](#8628) - @nygmaaa made their first contribution in [#8642](#8642) - @youta1119 made their first contribution in [#8646](#8646) - @chancez made their first contribution in [#8589](#8589) - @dector made their first contribution in [#8635](#8635) - @tak848 made their first contribution in [#8649](#8649) ## 📦 Aqua Registry Updates #### New Packages (5) - [`acsandmann/rift`](https://github.com/acsandmann/rift) - [`alltuner/mise-completions-sync`](https://github.com/alltuner/mise-completions-sync) - [`berbicanes/apiark`](https://github.com/berbicanes/apiark) - [`gitlab.com/graphviz/graphviz`](https://github.com/gitlab.com/graphviz/graphviz) - [`jorgelbg/pinentry-touchid`](https://github.com/jorgelbg/pinentry-touchid) #### Updated Packages (7) - [`UpCloudLtd/upcloud-cli`](https://github.com/UpCloudLtd/upcloud-cli) - [`aquaproj/registry-tool`](https://github.com/aquaproj/registry-tool) - [`go-swagger/go-swagger`](https://github.com/go-swagger/go-swagger) - [`gopinath-langote/1build`](https://github.com/gopinath-langote/1build) - [`sassman/t-rec-rs`](https://github.com/sassman/t-rec-rs) - [`sharkdp/fd`](https://github.com/sharkdp/fd) - [`temporalio/cli`](https://github.com/temporalio/cli)
Adding https://pi.dev/ agent.
Currently I install it as:
Tar from releases:
$ tar --list -f pi-linux-x64.tar.gz | grep pi/pi pi/pi