refactor(go): rename go_* settings to go.* namespace

[jdbruijn]

Rename all Go settings from flat go_* format to nested go.* namespace for consistency with other language settings (node.*, python.*, ruby.*).

Old setting names are preserved as deprecated aliases for backward compatibility.

Changes

• go_default_packages_file → go.default_packages_file
• go_download_mirror → go.download_mirror
• go_repo → go.repo
• go_set_gobin → go.set_gobin
• go_set_gopath → go.set_gopath
• go_set_goroot → go.set_goroot
• go_skip_checksum → go.skip_checksum

Also adds documentation note about MISE_GO_DEFAULT_PACKAGES_FILE env var (original PR intent).

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the Go language documentation by adding a crucial detail about configuring the default packages file. It clarifies how users can override the default location for Go packages, enhancing the flexibility and usability of the mise tool for Go projects.

Highlights

• Documentation Update: Added a note to the Go language documentation explaining how to specify a non-default location for the MISE_GO_DEFAULT_PACKAGES_FILE variable.

Changelog

• docs/lang/go.md
  • Added a note about MISE_GO_DEFAULT_PACKAGES_FILE.

Activity

• No specific activity (comments, reviews, progress) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly adds documentation for the MISE_GO_DEFAULT_PACKAGES_FILE setting, which was previously undocumented. The change is a valuable addition. I have a minor suggestion to improve the wording for better clarity and consistency with the rest of the documentation.

[gemini-code-assist]

For improved clarity and consistency, consider rephrasing this sentence to explicitly state that it's an environment variable and that it overrides the default path.

Suggested change

	You can specify a non-default location of this file by setting a `MISE_GO_DEFAULT_PACKAGES_FILE` variable.
	You can override the default location of this file by setting the `MISE_GO_DEFAULT_PACKAGES_FILE` environment variable.

[jdbruijn]

FYI I kept it in-line with e.g. the Node.js.

[greptile-apps]

Greptile Summary

This PR refactors Go-specific settings from a flat go_* naming convention to a nested go.* namespace, consistent with how other language settings are structured (e.g., node.*, python.*, ruby.*). The seven affected settings are each given a new canonical go.* form while the old names are preserved as hidden deprecated aliases.

Key changes:

• settings.toml: Adds new [go.*] entries as canonical settings and converts old [go_*] entries to deprecated hidden aliases
• src/config/settings.rs: Adds migration logic in set_hidden_configs to copy go_* → go.* at runtime (same pattern as cargo_binstall)
• src/plugins/core/go.rs: All references updated to use the new settings.go.* accessors — no functional change
• schema/mise.json: Regenerated schema correctly reflects new go object with nested properties, and marks go_* flat keys as deprecated
• e2e/config/test_config_ignore: Test updated to use go.download_mirror instead of go_download_mirror

The implementation is correct and consistent with existing codebase patterns. One minor issue with a misleading deprecation message is noted below.

Confidence Score: 5/5

Safe to merge — straightforward setting rename with no functional changes and correct backward-compatibility handling.

All remaining findings are P2 (a misleading deprecation string that has no runtime effect since deprecated_warn_at/deprecated_remove_at are not set). The refactoring correctly follows existing patterns, backward compatibility is preserved via hidden deprecated aliases, and the migration logic in set_hidden_configs matches the cargo_binstall precedent.

settings.toml line 753 has a misleading deprecated message for go.set_gopath, but it is purely cosmetic.

Important Files Changed

Filename	Overview
settings.toml	Adds new canonical [go.] settings and converts old [go_] entries to deprecated hidden aliases; the go.set_gopath deprecated message has a misleading 'goroot' reference
src/config/settings.rs	Adds go_* → go.* migration in set_hidden_configs, consistent with cargo_binstall pattern; no warn_deprecated calls (intentional, no warn_at/remove_at dates defined)
src/plugins/core/go.rs	All settings references updated to settings.go.* namespace; no functional changes, straightforward accessor rename
schema/mise.json	Regenerated schema correctly adds go nested object with all seven properties and marks flat go_* keys as deprecated
e2e/config/test_config_ignore	Test correctly updated to use go.download_mirror instead of go_download_mirror

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[User config: go_download_mirror / go.download_mirror] --> B{set_hidden_configs}
    B -->|go_default_packages_file set| C[copy → go.default_packages_file]
    B -->|go_download_mirror set| D[copy → go.download_mirror]
    B -->|go_repo set| E[copy → go.repo]
    B -->|go_set_gobin set| F[copy → go.set_gobin]
    B -->|go_set_gopath set| G[copy → go.set_gopath]
    B -->|go_set_goroot set| H[copy → go.set_goroot]
    B -->|go_skip_checksum set| I[copy → go.skip_checksum]
    C & D & E & F & G & H & I --> J[GoPlugin reads settings.go.*]
    J --> K[install / exec_env / get_tarball_url / etc.]

Loading

_{Reviews (2): Last reviewed commit: "docs(go): remove manual env var note" | Re-trigger Greptile}

[jdx]

the better fix would be to rename the setting go.default_packages_file

[jdbruijn]

the better fix would be to rename the setting go.default_packages_file

I've tried to rename but ran into the following error, after changing the name in settings.toml and running mise run render. For me it's not worth the time TBH, sorry, to debug that issue and try to get it fixed and tested. I'll happily update the docs with changes, but I don't have time for the rename. LMK if you want doc changes. The environment variable is just another way to specify the file, which I just noticed missed the documentation. In the end I just have added the go:<package> syntax in the config file BTW, so that also makes this low priority for me.

[build]   --- stderr
[build]   /Users/me/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/aws-lc-sys-0.37.0/aws-lc/include/openssl/base.h:61:10: fatal error: 'stdlib.h' file not found
[build]
[build]   thread 'main' (9963053) panicked at /Users/me/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/aws-lc-sys-0.37.0/builder/sys_bindgen.rs:144:10:
[build]   Unable to generate bindings.: ClangDiagnostic("/Users/me/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/aws-lc-sys-0.37.0/aws-lc/include/openssl/base.h:61:10: fatal error: 'stdlib.h' file not found\n")