Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a routine release of Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Greptile SummaryThis is the Key changes to review:
Confidence Score: 3/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[moon version requested] --> B{version_constraint eval}
B --> C["Version == @moonrepo/cli@0.12.0\nno_asset: true"]
B --> D["semver(<= 0.1.0)\nformat: raw, rosetta2\nsupported: darwin/windows/amd64"]
B --> E["semver(<= 0.11.1)\nformat: raw, musl\nsupported: darwin/windows/amd64"]
B --> F["semver(<= 1.41.8)\nformat: raw, all platforms\n⚠️ no supported_envs"]
B --> G["true (latest)\nformat: tar.xz\nsupported: linux/darwin-arm64/windows-amd64"]
G --> H{goos override}
H --> I["goos: darwin\namd64: amd64 ⚠️ dead code\n(darwin/amd64 not in supported_envs)"]
H --> J["goos: windows\nformat: zip\nfiles: moon, moonx ⚠️ no src path"]
J --> K{zip layout?}
K --> L["root: moon.exe ✅"]
K --> M["subdir/moon.exe ❌ extraction fails"]
Last reviewed commit: 6a3438e |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request is a standard release, bumping the version to 2026.3.6 across various files and adding two new packages to the Aqua Registry. The changes are mostly straightforward version updates. I have one suggestion to improve the maintainability of one of the new package definition files by combining redundant version override rules.
| - version_constraint: Version == "v0.0.17" | ||
| asset: fauxrpc_{{trimV .Version}}_{{.OS}}_{{.Arch}}.{{.Format}} | ||
| format: tar.gz | ||
| checksum: | ||
| type: github_release | ||
| asset: fauxrpc_{{trimV .Version}}_checksums.txt | ||
| algorithm: sha256 | ||
| - version_constraint: semver("<= 0.0.16") | ||
| asset: fauxrpc_{{trimV .Version}}_{{.OS}}_{{.Arch}}.{{.Format}} | ||
| format: tar.gz | ||
| checksum: | ||
| type: github_release | ||
| asset: fauxrpc_{{trimV .Version}}_checksums.txt | ||
| algorithm: sha256 |
There was a problem hiding this comment.
These two version_overrides blocks are identical except for the version_constraint. They can be combined into a single block using semver("<= 0.0.17") to improve maintainability and reduce duplication.
- version_constraint: semver("<= 0.0.17")
asset: fauxrpc_{{trimV .Version}}_{{.OS}}_{{.Arch}}.{{.Format}}
format: tar.gz
checksum:
type: github_release
asset: fauxrpc_{{trimV .Version}}_checksums.txt
algorithm: sha256
Hyperfine Performance
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.3.5 x -- echo |
23.0 ± 0.3 | 22.3 | 27.2 | 1.00 |
mise x -- echo |
23.4 ± 0.3 | 22.7 | 25.1 | 1.01 ± 0.02 |
mise env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.3.5 env |
22.6 ± 0.7 | 22.0 | 28.6 | 1.00 |
mise env |
22.9 ± 0.3 | 22.3 | 26.1 | 1.02 ± 0.03 |
mise hook-env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.3.5 hook-env |
23.2 ± 0.2 | 22.5 | 23.9 | 1.00 |
mise hook-env |
23.7 ± 0.5 | 23.1 | 29.8 | 1.02 ± 0.02 |
mise ls
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.3.5 ls |
22.4 ± 0.3 | 22.0 | 25.6 | 1.00 |
mise ls |
23.0 ± 0.3 | 22.3 | 24.5 | 1.02 ± 0.02 |
xtasks/test/perf
| Command | mise-2026.3.5 | mise | Variance |
|---|---|---|---|
| install (cached) | 150ms | 151ms | +0% |
| ls (cached) | 81ms | 82ms | -1% |
| bin-paths (cached) | 84ms | 85ms | -1% |
| task-ls (cached) | 813ms | 804ms | +1% |
mise-en-dev
force-pushed
the
release
branch
4 times, most recently
from
15514ae to
8a093eb
Compare
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
crates/aqua-registry/aqua-registry/pkgs/sudorandom/fauxrpc/registry.yaml
Show resolved
Hide resolved
mise-en-dev
force-pushed
the
release
branch
5 times, most recently
from
a5f3526 to
05fe317
Compare
crates/aqua-registry/aqua-registry/pkgs/princjef/gomarkdoc/registry.yaml
Show resolved
Hide resolved
crates/aqua-registry/aqua-registry/pkgs/remko/age-plugin-se/registry.yaml
Show resolved
Hide resolved
crates/aqua-registry/aqua-registry/pkgs/betterleaks/betterleaks/registry.yaml
Show resolved
Hide resolved
mise-en-dev
force-pushed
the
release
branch
5 times, most recently
from
bc3ac69 to
6df9bb5
Compare
| overrides: | ||
| - goos: darwin | ||
| replacements: | ||
| amd64: amd64 |
There was a problem hiding this comment.
Dead goos: darwin replacement override
The goos: darwin override sets amd64: amd64, which exists to override the top-level amd64: x86_64 replacement. However, supported_envs for this block only includes darwin/arm64 (line 84) — darwin/amd64 is explicitly excluded. Since the only reachable darwin platform is arm64, the arch value being substituted is always arm64 (→ aarch64), and the amd64 replacement in this override is never triggered.
This dead override could be safely removed unless there are plans to add darwin/amd64 back to supported_envs in the future:
| overrides: | |
| - goos: darwin | |
| replacements: | |
| amd64: amd64 | |
| overrides: | |
| - goos: windows | |
| format: zip | |
| files: | |
| - name: moon | |
| - name: moonx |
| - goos: windows | ||
| format: zip | ||
| files: | ||
| - name: moon | ||
| - name: moonx |
There was a problem hiding this comment.
Windows files entries missing src paths
The top-level files block (lines 58–62) explicitly sets src: "{{.AssetWithoutExt}}/moon" and src: "{{.AssetWithoutExt}}/moonx", indicating the binaries live inside a subdirectory within the archive (matching the goreleaser convention of moon_cli-<arch>-<os>/moon).
The goos: windows override specifies its own files block with only name fields and no src. When aqua resolves these entries it will default src to the bare name value and look for the binaries at the root of the zip. If the Windows zip follows the same subdirectory layout as the tar.xz archives, extraction will fail with a "file not found" error.
Could you confirm that the Windows zip places moon.exe / moonx.exe at the archive root rather than in a subdirectory? If the layout is nested, the fix would be:
| - goos: windows | |
| format: zip | |
| files: | |
| - name: moon | |
| - name: moonx | |
| - goos: windows | |
| format: zip | |
| files: | |
| - name: moon | |
| src: "{{.AssetWithoutExt}}/moon" | |
| - name: moonx | |
| src: "{{.AssetWithoutExt}}/moonx" |
2 participants
🐛 Bug Fixes
🚜 Refactor
📚 Documentation
📦 Registry
New Contributors
📦 Aqua Registry Updates
New Packages (6)
betterleaks/betterleaksmajorcontext/moatprincjef/gomarkdocremko/age-plugin-sesudorandom/fauxrpcswanysimon/mdlintUpdated Packages (1)
moonrepo/moon