Conversation
Upstream bug: sd v1.1.0 binary reports "sd 1.0.0". Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a failing version test for the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Greptile SummaryThis PR disables the version-check test for the
Confidence Score: 5/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[mise installs sd via registry/sd.toml] --> B{Version test defined?}
B -- "Before PR (test active)" --> C["Run: sd --version"]
C --> D{"Output matches\n'sd {{version}}'?"}
D -- "sd v1.1.0 (bug: reports 1.0.0)" --> E[❌ Test FAILS — upstream bug]
D -- Expected --> F[✅ Test passes]
B -- "After PR (test commented out)" --> G[⏭ Version test skipped]
G --> H[Install succeeds regardless of reported version]
Last reviewed commit: 5d02bdc |
There was a problem hiding this comment.
Code Review
The pull request disables the sd version test due to an upstream bug where sd v1.1.0 incorrectly reports sd 1.0.0. While this addresses the immediate test failure, it's important to consider a more robust long-term solution to ensure version validation remains active.
Note: Security Review has been skipped due to the limited scope of the PR.
| backends = ["aqua:chmln/sd", "cargo:sd"] | ||
| description = "Intuitive find & replace CLI (sed alternative)" | ||
| test = { cmd = "sd --version", expected = "sd {{version}}" } | ||
| # test = { cmd = "sd --version", expected = "sd {{version}}" } # upstream bug: v1.1.0 reports "sd 1.0.0" |
There was a problem hiding this comment.
Disabling a test, even temporarily, reduces confidence in the system's correctness. While the upstream bug necessitates this workaround, it's crucial to have a clear plan for re-enabling or adapting this test. Leaving it commented out indefinitely could lead to regressions or missed opportunities to validate the sd tool's version behavior. Please consider adding a specific reference to the upstream issue and a clear action item for when it should be re-enabled or modified.
| # test = { cmd = "sd --version", expected = "sd {{version}}" } # upstream bug: v1.1.0 reports "sd 1.0.0" | |
| # test = { cmd = "sd --version", expected = "sd {{version}}" } # TODO(upstream_issue_link): Re-enable/adapt test when upstream bug (v1.1.0 reports v1.0.0) is fixed. |
Hyperfine Performance
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.3.3 x -- echo |
23.2 ± 0.3 | 22.6 | 28.6 | 1.00 ± 0.02 |
mise x -- echo |
23.2 ± 0.4 | 22.6 | 29.8 | 1.00 |
mise env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.3.3 env |
22.7 ± 0.6 | 22.1 | 28.2 | 1.00 ± 0.03 |
mise env |
22.7 ± 0.3 | 22.0 | 27.0 | 1.00 |
mise hook-env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.3.3 hook-env |
23.4 ± 0.4 | 22.9 | 27.5 | 1.00 ± 0.02 |
mise hook-env |
23.4 ± 0.2 | 22.8 | 24.7 | 1.00 |
mise ls
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.3.3 ls |
22.8 ± 0.3 | 22.2 | 24.8 | 1.00 |
mise ls |
22.9 ± 0.2 | 22.1 | 24.2 | 1.00 ± 0.02 |
xtasks/test/perf
| Command | mise-2026.3.3 | mise | Variance |
|---|---|---|---|
| install (cached) | 151ms | 151ms | +0% |
| ls (cached) | 83ms | 82ms | +1% |
| bin-paths (cached) | 86ms | 84ms | +2% |
| task-ls (cached) | 818ms | 825ms | +0% |
### 🚀 Features - **(github)** keep exe extensions on Windows by @iki in [#8424](#8424) - **(task)** add `interactive` field for exclusive terminal access by @jdx in [#8491](#8491) - add header comment to generated lockfiles by @ivy in [#8481](#8481) - runtime musl/glibc detection for correct libc variant selection by @jdx in [#8490](#8490) ### 🐛 Bug Fixes - **(github)** use registry platform options during install by @jdx in [#8492](#8492) - **(http)** store tool opts as native TOML to fix platform switching by @jdx in [#8448](#8448) - **(installer)** error if MISE_INSTALL_PATH is a directory by @jdx in [#8468](#8468) - **(prepare)** resolve sources/outputs relative to `dir` when set by @jdx in [#8472](#8472) - **(ruby)** fetch precompiled binary by release tag instead of listing all releases by @jdx in [#8488](#8488) - **(schema)** support structured objects in task depends by @risu729 in [#8463](#8463) - **(task)** replace println!/eprintln! with calm_io in task output macros by @vmaleze in [#8485](#8485) - handle scoped npm package names without backend prefix by @jdx in [#8477](#8477) ### 📦️ Dependency Updates - update ghcr.io/jdx/mise:copr docker digest to c485c4c by @renovate[bot] in [#8484](#8484) - update ghcr.io/jdx/mise:alpine docker digest to 8118bc7 by @renovate[bot] in [#8483](#8483) ### 📦 Registry - disable sd version test by @jdx in [#8489](#8489) ### New Contributors - @ivy made their first contribution in [#8481](#8481) - @iki made their first contribution in [#8424](#8424) ## 📦 Aqua Registry Updates #### New Packages (5) - [`datadog-labs/pup`](https://github.com/datadog-labs/pup) - [`k1LoW/mo`](https://github.com/k1LoW/mo) - [`rtk-ai/rtk`](https://github.com/rtk-ai/rtk) - [`suzuki-shunsuke/docfresh`](https://github.com/suzuki-shunsuke/docfresh) - [`yashikota/exiftool-go`](https://github.com/yashikota/exiftool-go) #### Updated Packages (6) - [`cloudflare/cloudflared`](https://github.com/cloudflare/cloudflared) - [`mozilla/sccache`](https://github.com/mozilla/sccache) - [`owenlamont/ryl`](https://github.com/owenlamont/ryl) - [`spinel-coop/rv`](https://github.com/spinel-coop/rv) - [`technicalpickles/envsense`](https://github.com/technicalpickles/envsense) - [`weaviate/weaviate`](https://github.com/weaviate/weaviate)
Summary
sd 1.0.0in--versionoutput🤖 Generated with Claude Code
Note
Low Risk
Only comments out a registry test and does not affect runtime behavior; risk is limited to reduced CI/validation coverage for
sd.Overview
Disables the
sdpackage version check by commenting out thesd --versiontest inregistry/sd.toml, noting an upstream bug where v1.1.0 reportssd 1.0.0.Written by Cursor Bugbot for commit 5d02bdc. This will update automatically on new commits. Configure here.