Repository navigation
fix(chat): native subagent prompts render as prompts, not agent rows - #75
Merged
Merged
Conversation
isAgentDeliveredMessage counted every provider-written user message as a T3 agent delivery. Provider adapters write those only for the prompts a native subagent runs, so subagent threads showed each prompt as a folded "Agent" work row, and the launch answer disappeared into the next fold. Provider-sourced messages are now never agent deliveries. MCP sends, coordination results and Home reports keep their folded rows on web and mobile.
github-actions
Bot
added
vouch:trusted
 [Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryNative subagent prompts now stay visible as prompts instead of becoming folded agent work rows.
Reviews (1) · Last reviewed commit: "fix(chat): native subagent prompts rende..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
In a provider-native subagent thread, each prompt from the parent agent rendered as a folded "Agent" work row on web and mobile, and the subagent's first answer disappeared into the next "Worked for" fold. The fork's
isAgentDeliveredMessage(from #38) treatedcreationSource: "provider"and anysenderThreadIdas an agent delivery, and provider adapters write exactly that for native subagent prompts.What changed
isAgentDeliveredMessageinpackages/contracts/src/home.tsreturns false for any message withcreationSource: "provider". MCP sends ("mcp"), coordination results and Home reports ("server") still fold.senderThreadId.Scope
Fork-only code; one contracts change covers web, mobile and client-runtime. Buffered wakes keep rendering as notification rows, because they become
notificationitems before this check.Verification
MessagesTimeline.logicsubagent fold test, red on Fork CI since merge: sync upstream main through 077fd62222 #71, passes. Withhome.tsreverted it and the new fork case fail. Web: 140 passed.Model and harness: Claude Opus 5.5 (lead, implementation, review) via Claude Code in T3 Code.
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.