refactor(app): replace ion-img with img#82
Merged
Merged
Conversation
…one, zoneless Angular
… to silence vite warning
brandyscarney
commented
Jul 2, 2026
| @for (photo of photoService.photos(); track photo.filepath; let position = $index) { | ||
| <ion-col size="6"> | ||
| <ion-img [src]="photo.webviewPath" (click)="showActionSheet(photo, position)"></ion-img> | ||
| <button (click)="showActionSheet(photo, position)"> |
Member
Author
There was a problem hiding this comment.
I wrapped the <img> in a button to resolve the Angular eslint error here: https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin-template/docs/rules/click-events-have-key-events.md
brandyscarney
commented
Jul 2, 2026
| <ion-col size="6"> | ||
| <ion-img [src]="photo.webviewPath" (click)="showActionSheet(photo, position)"></ion-img> | ||
| <button (click)="showActionSheet(photo, position)"> | ||
| <img [src]="photo.webviewPath" [attr.alt]="'Photo ' + (position + 1)" loading="lazy"/> |
Member
Author
There was a problem hiding this comment.
alt must be added to img for a11y: https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin-template/docs/rules/alt-text.md
brandyscarney
commented
Jul 2, 2026
Member
Author
There was a problem hiding this comment.
These styles were added for the new button wrapper.
OS-jacobbell
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
ion-imgwithimgfor the deprecation for v9.