Skip to content

content: ion-backdrop basic usage demo should have tinted backdrop #3110

Closed

Description

@harlig

Describe the Bug

The "basic usage" example of the ion-backdrop page isn't functional. Clicking on it does nothing.

Expected Behavior

The example should demonstrate the backdrop functionality.

Steps to Reproduce

  1. Navigate to ion-backdrop docs page
  2. Go to "Basic Usage" section
  3. Attempt to interact with the example

Screenshots

ion-backdrop.mov

Operating System

No response

Browser

Firefox 117.0

Version

No response

Additional Information

No response

Activity

  1. self-assigned this
    on Sep 8, 2023
  2. averyrousseau commented on Sep 8, 2023

    @averyrousseau
    Contributor

    Thank you for the issue. As described in the paragraph above the demo, the behavior you're describing actually is the backdrop functionality -- it prevents clicking or tapping on any of the elements underneath it. Does that help answer your question?

  3. removed their assignment
    on Sep 8, 2023
  4. harlig commented on Sep 8, 2023

    @harlig
    Author

    I did see that but I guess the example was then confusing to me since it doesn't feel like it's truly demonstrating the backdrop functionality. The following example showing a clickable overlay paired with the backdrop seems like a much more common use case and perhaps should be used as the primary example.

  5. added and removed
    needs: replyIssues that need more information from the author
    on Sep 8, 2023
  6. averyrousseau commented on Sep 11, 2023

    @averyrousseau
    Contributor

    Would it help if the backdrop was tinted to better mimic the functionality it'd have in an overlay? The idea behind the demo is to show the backdrop's functionality by itself, without implying that it necessarily needs to be used with any other components.

  7. harlig commented on Sep 12, 2023

    @harlig
    Author

    Personally that'd be more clear to me. I understand the desire to show the basic usage without any other components, I just think for this component in particular it may make sense to show with a tinted backdrop.

  8. added and removed
    needs: replyIssues that need more information from the author
    on Sep 12, 2023
  9. changed the title [-]bug: ion-backdrop - "Basic Usage" example isn't functional[/-] [+]content: ion-backdrop basic usage demo should have tinted backdrop[/+] on Sep 12, 2023
  10. added
    contentIssues related to the contents of the documentation website
    on Sep 12, 2023
  11. averyrousseau commented on Oct 17, 2023

    @averyrousseau
    Contributor

    I've added a tint to the backdrop in #3200. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    contentIssues related to the contents of the documentation website

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions