Repository navigation
Conversation
The default VAE picker only offered VAEs of the model's own base, so models that decode with another base's VAE (MOSS-Image, FLUX.3, ERNIE-Image, Z-Image, Krea-2, Qwen-Image, Anima) saw none. It now uses the backend's VAE compatibility rule, the same one Generate applies. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ts first model First-run Generate settings were built without the model's default VAE, so a new project started with none even when the model's default settings named one. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
6 of 7 tasks
Member
|
Thanks for tracking this down, the MOSS/FLUX.2 VAE picker gap is real. #10263 covers both parts of this PR: the Model Manager VAE picker now uses Generate's VAE rule, and a new project's first model applies its default VAE (along with the new default components, which are also applied on model switch). Since both PRs touch the same five files, I'd rather not carry the change twice, so I'm closing this one in favour of #10263. Your report is credited there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A model's default VAE could not be chosen, or applied, when the model decodes with another base's VAE (MOSS-Image, FLUX.3, ERNIE-Image, Ideogram 4, Z-Image, Krea-2, Qwen-Image, Anima).
I've only manually tested this with MOSS image, but it should apply to other families.
QA Instructions
pnpm test src/features/generation(1657 passed),pnpm run lint:tsc,pnpm run format:check, oxlint on the touched folders, and the architecture dependency policy test all pass.AccountModelsUiProvider.browser.test.tsx) andcheck:release; Chromium is not installed in the author's worktree. The picker was tested manually.Review
Self-reviewed. Remaining limits: the picker lists no VAEs while the capability rules are loading or if they fail to load. A new project applies a default VAE only when the model it starts with has one.
Checklist
What's Newcopy (if doing a release after this PR)🤖 Generated with Claude Code