Repository navigation
refactor(palette): upgrade Chakra UI to 3.38 and build the command palette on Command - #10247
Open
joshistoast wants to merge 5 commits into
Open
joshistoast wants to merge 5 commits into
joshistoast wants to merge 5 commits into
Conversation
Pulls Ark UI 5.40 and Zag 1.47, which reconciles controlled values on Activity reconnect upstream, so the local Zag patch is removed. Tests follow Zag 1.47: menu selections carry modifiers, exits unmount unless their animation runs, and the preview video stand-in no longer races real media loading.
Chakra 3.38 sizes the stepper from the root's stock input height; pin it to the field again. Drop the scroll area override that 3.38 now covers per axis.
Zag 1.47 adds a results live region with English text; the platform combobox now passes translated strings.
Input, list, items and footer use Chakra's Command parts and combobox for highlight, keyboard and selection; search, scopes, stages and virtualization are unchanged. Command code loads in its own lazy chunk instead of the startup Chakra chunk.
The startup Chakra chunk grows 19 KB with the upgrade; timings, request counts and owner sets are unchanged.
5 of 7 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades Chakra UI to 3.38 (Ark UI 5.40, Zag 1.47) and rebuilds the command palette on Chakra's new
Commandprimitives. The palette looks and behaves as before; before/after screenshots are pixel-identical.Commandparts, and Chakra's combobox owns highlight, arrow keys, Enter, hover and the ARIA wiring. Our search, providers, scopes, stages, date tokens, recents and the virtualized list are unchanged. The platformDialogshell stays, sinceCommand.Dialogbypasses modal presence and the menu-teardown guard. Click runs the primary action and Mod+Enter the secondary, as before. Chakra'sCommandcode loads in its own lazy chunk.useTrackpatch is removed because 1.47 includes the fix; a scroll area override that 3.38 covers is removed.QA Instructions
pnpm check:release(Node 22.14): lint, types, architecture, 13,232 unit and 4,677 browser tests, fixtures, build and browser performance gates, project-file journeys, accessibility (includingworkbench-keep-alive-state), three-engine smoke. All pass. One run had a single load failure inGalleryBoardMenu.browser.test.tsx("leaves Retry in place but disabled as the dialog closes"); it passes 5/5 in isolation on both 3.37 and 3.38.Review
Resolved: number input stepper height, untranslated combobox announcements, Ctrl/⌘+click briefly running the secondary action, Command code in the startup chunk, tests updated for Zag 1.47 (menu selection modifiers, presence unmounting exits whose animation is paused, a preview video stand-in racing real media loading).
Remaining: on Apple platforms Zag also announces the highlighted option in its own live region, so VoiceOver may hear it twice.
Bytes: the startup Chakra chunk grows 19 KB (751,079 → 770,322) from the upgrade itself; only byte figures were re-recorded, and timings, request counts and owner sets are unchanged.
Checklist
What's Newcopy (if doing a release after this PR)Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.