Fix Waitlist button padding issue#11079
Merged
jimchamp merged 5 commits intointernetarchive:masterfrom Aug 6, 2025
Merged
Conversation
…as a specification of cta-button-group in book.less; this change should make all paddings uniform.
Collaborator
|
@doct0r-furcation were you able to run this locally (or in gitpod) to see it working? If so, can you share a screenshot? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #11079 +/- ##
==========================================
+ Coverage 17.14% 17.85% +0.71%
==========================================
Files 91 92 +1
Lines 4981 5096 +115
Branches 867 887 +20
==========================================
+ Hits 854 910 +56
- Misses 3588 3639 +51
- Partials 539 547 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Member
|
Squash on merge, if possible please :) |
jimchamp
approved these changes
Aug 6, 2025
Collaborator
jimchamp
left a comment
There was a problem hiding this comment.
Thanks @doct0r-furcation! Everything is looking good on testing for all screen sizes.
This was referenced Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Join waitlist had a padding error; i've added the join waitlist form as a specification of cta-button-group in book.less; this change should make all paddings uniform.
Issue #11036
Fix
Technical
The padding for all form buttons should be uniform after merging this fix.
Testing
Refer to #11036 (comment)
Screenshot
I am not entirely sure how to check the browser/UI implementation of the issue.
Stakeholders
@RayBB @mekarpeles