add typehints to accounts/model.py

[RayBB]

Adding typehints where we don't need to change things.

Closes #

Technical

Testing

Screenshot

Stakeholders

[Copilot]

Pull Request Overview

This PR adds Python type annotations to many functions in accounts/model.py and introduces a runtime type check for the S3 auth URL.

• Added parameter and return type hints across multiple methods.
• Introduced a TypeError check if the S3 auth URL is not a string.
• Simplified authenticate by removing the redundant else branch.

Comments suppressed due to low confidence (3)

openlibrary/accounts/model.py:73

• The parameter name hash shadows the built-in hash() function. Consider renaming it to hash_value or encoded_hash for clarity.

def verify_hash(secret_key, text, hash) -> bool:

openlibrary/accounts/model.py:289

• Returning False alongside a Link object can be confusing for API consumers. Consider returning Optional[Link] and use None instead of False for the no-link case.

    def get_activation_link(self) -> Link | bool:

openlibrary/accounts/model.py:296

• Similar to get_activation_link, it may be clearer to use Optional[Link] and return None instead of False.

    def get_password_reset_link(self) -> Link | bool:

[jimchamp]

Was this change intentional? It seems out-of-scope for this PR.

[RayBB]

It is needed to ensure that a string is passed to the get function.

But if we want to just assume the url is always a string we can add a noqa to skip this check here.

openlibrary/accounts/model.py:760: error: Argument 1 to "get" has incompatible
type "Any | None"; expected "str | bytes"  [arg-type]
                    url,

PS: It's needed because once you add types to the function parameters the body of the function is type checked.