refactor(core): normalized boolean config resolution#2433
Merged
Conversation
aryamohanan
commented
Mar 26, 2026
aryamohanan
commented
Mar 26, 2026
|
aryamohanan
commented
Mar 26, 2026
| expect(result).to.equal(false); | ||
| }); | ||
|
|
||
| it.skip('should prioritize env var over config value', () => { |
Contributor
Author
There was a problem hiding this comment.
skipped precdence test for now, enable this in later PR's
aryamohanan
changed the title
kirrg001
reviewed
Mar 26, 2026
| }); | ||
|
|
||
| it('should prioritize env var over config value', () => { | ||
| it.skip('should prioritize env var over config value', () => { |
Contributor
There was a problem hiding this comment.
I guess its skipped because it fails currently?
Maybe put a TODO to not forget about it :)
42 tasks
aryamohanan
added a commit
that referenced
this pull request
Apr 10, 2026
aryamohanan
added a commit
that referenced
this pull request
Apr 13, 2026
kirrg001
pushed a commit
that referenced
this pull request
May 12, 2026
aryamohanan
added a commit
that referenced
this pull request
May 14, 2026
aryamohanan
added a commit
that referenced
this pull request
May 15, 2026
aryamohanan
added a commit
that referenced
this pull request
May 15, 2026
aryamohanan
added a commit
that referenced
this pull request
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normalized boolean config
refs https://jsw.ibm.com/browse/INSTA-82698