Skip to content

fix: use module logger instead of root logger in exceptions.py #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Bahtya wants to merge 2 commits into from
Closed

fix: use module logger instead of root logger in exceptions.py #702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea5ac31
fix: use module logger instead of root logger in exceptions.py
Bahtya Apr 8, 2026
4fa8d6e
fix(ci): replace wget with curl in influxdb-onboarding.sh
Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion influxdb_client/client/exceptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def _get_message(self, response):
try:
return json.loads(response.data)["message"]
except Exception as e:
logging.debug(f"Cannot parse error response to JSON: {response.data}, {e}")
logger.debug(f"Cannot parse error response to JSON: {response.data}, {e}")
return response.data

# Header
Expand Down
8 changes: 7 additions & 1 deletion scripts/influxdb-onboarding.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,13 @@
set -e

echo "Wait to start InfluxDB 2.0"
wget -S --spider --tries=20 --retry-connrefused --waitretry=5 http://localhost:8086/metrics
for i in $(seq 1 20); do
Copy link
Copy Markdown
Contributor

@karel-rehor karel-rehor Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why the simpler and cleaner wget one-liner needs to be replaced. Ideally PRs should not introduce extra complexity if it is not needed.

if curl -sf -o /dev/null http://localhost:8086/metrics; then
break
fi
echo "Attempt $i failed, retrying in 5 seconds..."
sleep 5
done

echo
echo "Post onBoarding request, to setup initial user (my-user@my-password), org (my-org) and bucketSetup (my-bucket)"
Expand Down