Adding backpressure design pattern #3233#3249
Adding backpressure design pattern #3233#3249iluwatar merged 8 commits intoiluwatar:masterfrom sanurah:master
Conversation
PR SummaryThis PR implements the backpressure design pattern in Java using Reactor. It includes a Changes
autogenerated by presubmit.ai |
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (3)
- 7c3ba8a: Merge branch 'iluwatar:master' into master
- 1fa515f: Adding backpressure pattern #3233
- b8f51f0: Initial commit backpressure
temp
Files Processed (11)
- backpressure/README.md (1 hunk)
- backpressure/etc/backpressure.png (0 hunks)
- backpressure/pom.xml (1 hunk)
- backpressure/src/main/java/com/iluwatar/backpressure/App.java (1 hunk)
- backpressure/src/main/java/com/iluwatar/backpressure/Publisher.java (1 hunk)
- backpressure/src/main/java/com/iluwatar/backpressure/Subscriber.java (1 hunk)
- backpressure/src/test/java/com/iluwatar/backpressure/AppTest.java (1 hunk)
- backpressure/src/test/java/com/iluwatar/backpressure/LoggerExtension.java (1 hunk)
- backpressure/src/test/java/com/iluwatar/backpressure/PublisherTest.java (1 hunk)
- backpressure/src/test/java/com/iluwatar/backpressure/SubscriberTest.java (1 hunk)
- pom.xml (1 hunk)
Actionable Comments (0)
Skipped Comments (0)
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Files Processed (10)
- backpressure/README.md (1 hunk)
- backpressure/pom.xml (1 hunk)
- backpressure/src/main/java/com/iluwatar/backpressure/App.java (1 hunk)
- backpressure/src/main/java/com/iluwatar/backpressure/Publisher.java (1 hunk)
- backpressure/src/main/java/com/iluwatar/backpressure/Subscriber.java (1 hunk)
- backpressure/src/test/java/com/iluwatar/backpressure/AppTest.java (1 hunk)
- backpressure/src/test/java/com/iluwatar/backpressure/LoggerExtension.java (1 hunk)
- backpressure/src/test/java/com/iluwatar/backpressure/PublisherTest.java (1 hunk)
- backpressure/src/test/java/com/iluwatar/backpressure/SubscriberTest.java (1 hunk)
- pom.xml (1 hunk)
Actionable Comments (0)
Skipped Comments (0)
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Files Processed (5)
- backpressure/src/main/java/com/iluwatar/backpressure/App.java (1 hunk)
- backpressure/src/main/java/com/iluwatar/backpressure/Publisher.java (1 hunk)
- backpressure/src/main/java/com/iluwatar/backpressure/Subscriber.java (1 hunk)
- backpressure/src/test/java/com/iluwatar/backpressure/PublisherTest.java (1 hunk)
- backpressure/src/test/java/com/iluwatar/backpressure/SubscriberTest.java (1 hunk)
Actionable Comments (0)
Skipped Comments (1)
-
backpressure/src/main/java/com/iluwatar/backpressure/Subscriber.java [36-42]
performance: "Inefficient delay simulation in
processItemmethod."
|
Check out the Sonar issue |
| @Slf4j | ||
| public class Subscriber extends BaseSubscriber<Integer> { | ||
|
|
||
| private static final Logger logger = LoggerFactory.getLogger(Subscriber.class); |
There was a problem hiding this comment.
No need to declare logger like this. With the Lombok annotation you automatically have LOGGER available.
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Files Processed (8)
- backpressure/pom.xml (1 hunk)
- backpressure/src/main/java/com/iluwatar/backpressure/App.java (1 hunk)
- backpressure/src/main/java/com/iluwatar/backpressure/Publisher.java (1 hunk)
- backpressure/src/main/java/com/iluwatar/backpressure/Subscriber.java (1 hunk)
- backpressure/src/test/java/com/iluwatar/backpressure/AppTest.java (1 hunk)
- backpressure/src/test/java/com/iluwatar/backpressure/LoggerExtension.java (1 hunk)
- backpressure/src/test/java/com/iluwatar/backpressure/PublisherTest.java (1 hunk)
- backpressure/src/test/java/com/iluwatar/backpressure/SubscriberTest.java (1 hunk)
Actionable Comments (0)
Skipped Comments (0)
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Files Processed (1)
- leader-followers/src/main/java/com/iluwatar/leaderfollowers/App.java (1 hunk)
Actionable Comments (0)
Skipped Comments (1)
-
leader-followers/src/main/java/com/iluwatar/leaderfollowers/App.java [70-76]
best practice: "Resource Management Improvement"
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- 817cfbc: Merge branch 'master' into master
Files Processed (0)
Actionable Comments (0)
Skipped Comments (0)
|
|
Looks good! Thank you for the contribution 🎉 @all-contributors please add @sanurah for code |



Pull Request Template
What does this PR do?
This PR is adding the backpressure design pattern
Relates to #3233