Skip to content

don't warn about TLS host verification when verify_peer is explicitly false#341

Merged
igrigorik merged 3 commits intoigrigorik:masterfrom
bidwrangler:master
Jun 15, 2020
Merged

don't warn about TLS host verification when verify_peer is explicitly false#341
igrigorik merged 3 commits intoigrigorik:masterfrom
bidwrangler:master

Conversation

@aharbick
Copy link
Copy Markdown
Contributor

Let me know if you think the tests are overkill.

@aharbick
Copy link
Copy Markdown
Contributor Author

FWIW this spec was already failing

  1) EventMachine::HttpRequest should detect deflate encoding
     Failure/Error: http.response_header["CONTENT_ENCODING"].should == "deflate"
     
       expected: "deflate"
            got: nil (using ==)
     # ./spec/external_spec.rb:92:in `block (5 levels) in <top (required)>'
     # /Users/aharbick/.rvm/gems/ruby-2.5.7@em-http/gems/eventmachine-1.2.7/lib/em/deferrable.rb:151:in `set_deferred_status'
     # /Users/aharbick/.rvm/gems/ruby-2.5.7@em-http/gems/eventmachine-1.2.7/lib/em/deferrable.rb:191:in `succeed'
     # ./lib/em-http/client.rb:113:in `unbind'
     # ./lib/em-http/client.rb:71:in `on_request_complete'
     # ./lib/em-http/http_connection.rb:204:in `block in post_init'
     # ./lib/em-http/http_connection.rb:219:in `<<'
     # ./lib/em-http/http_connection.rb:219:in `receive_data'
     # ./lib/em-http/http_connection.rb:26:in `receive_data'
     # /Users/aharbick/.rvm/gems/ruby-2.5.7@em-http/gems/eventmachine-1.2.7/lib/eventmachine.rb:195:in `run_machine'
     # /Users/aharbick/.rvm/gems/ruby-2.5.7@em-http/gems/eventmachine-1.2.7/lib/eventmachine.rb:195:in `run'
     # ./spec/external_spec.rb:84:in `block (3 levels) in <top (required)>'

Copy link
Copy Markdown
Owner

@igrigorik igrigorik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Nice work, ty!

@igrigorik igrigorik merged commit 157d5ff into igrigorik:master Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants