Skip to content

Repository navigation

feat(workflows): author checks, typed decisions, and bounded rework #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Igloczek wants to merge 11 commits into from
+4,781 −368
Draft

feat(workflows): author checks, typed decisions, and bounded rework #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d3e6a58
feat(workflows): author checks, typed decisions, and bounded rework
Igloczek Oct 9, 2026
c52b2a9
fix(workflows): address #27 post-sync review
Igloczek Oct 10, 2026
60656a9
fix(workflows): qualify reviewer field labels that still collide
Igloczek Oct 10, 2026
a67ed01
fix(workflows): consistent repeat wording and clearer check and decis…
Igloczek Oct 11, 2026
45496f6
test(workflows): match decision problem wording to step-titled problems
Igloczek Oct 11, 2026
d35a204
fix(workflows): stub plugin overlays in decision tests and fit graphs…
Igloczek Oct 11, 2026
7e12711
fix(workflows): scope decision fields and verify canonical limits
Igloczek Oct 12, 2026
c887b24
fix(workflows): save checks after clearing arguments
Igloczek Oct 13, 2026
c9a6d66
test(workflows): verify decisions through the shared graph
Igloczek Oct 13, 2026
2db7d6a
fix(workflows): show exact check timeout in minutes
Igloczek Oct 13, 2026
508f50c
fix(workflows): refresh persisted run actions under current rules
Igloczek Oct 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions apps/server/src/plugins/Workflows.testkit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,10 @@ export const fixture = Effect.gen(function* () {
holdCheck: () => {
checkExecution = Effect.never;
},
/** Result the next check commands return. */
setCheck: (result: { exitCode: number; timedOut: boolean; stdout: string }) => {
checkExecution = Effect.succeed({ ...result, stderr: "" });
},
threads,
restart: Effect.gen(function* () {
yield* runtime.close;
Expand Down
561 changes: 561 additions & 0 deletions apps/server/src/plugins/WorkflowsDecisions.test.ts
View file
Open in desktop

Large diffs are not rendered by default.

5 changes: 3 additions & 2 deletions apps/server/src/plugins/WorkflowsValidation.worker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ const definition = Schema.decodeUnknownSync(Definition)({
id: "complexity",
revision: 1,
title: "Complexity",
entry: "d0",
// The source runs first so every decision has a result to read.
entry: "source",
atLimit: "gate",
nodes: [
...Array.from({ length: count }, (_, index) => {
Expand All @@ -38,7 +39,7 @@ const definition = Schema.decodeUnknownSync(Definition)({
runtimeMode: "approval-required",
instruction: "Source",
report: { fields: [{ name: "ready", type: "boolean", required: true }] },
next: { to: "gate" },
next: { to: "d0" },
},
{ id: "gate", kind: "human", title: "Gate", approve: { to: "end" }, changes: { to: "end" } },
{ id: "end", kind: "end", title: "End", outcome: "completed" },
Expand Down
Loading
Loading