Fix exception from deleting a directory ZipEntry in a ZipFile#295
Merged
piksel merged 1 commit intoicsharpcode:masterfrom Jan 3, 2019
Merged
Fix exception from deleting a directory ZipEntry in a ZipFile#295piksel merged 1 commit intoicsharpcode:masterfrom
piksel merged 1 commit intoicsharpcode:masterfrom
Conversation
Member
|
So, the consequence of this bug is that the entry name ends with a slash when created with Test looks good. I'll try to release a bugfix update with this commit soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZipFile.FindExistingUpdate(ZipEntry)would always return -1 for directoryZipEntrys due to usingGetTransformedFileNameon allZipEntrys. As a result,ZipFile.Delete(ZipEntry)would always throw an exception when passed a directoryZipEntry. The fix is to callGetTransformedDirectoryNamefor directoryZipEntrys.I updated the test
AddAndDeleteEntriesinZipFileHandling.csto add and delete a directory; this test failed without the change toZipFile.FindExistingUpdate.I believe issue #290 is related.
I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.