Skip to content

Relax layout requirements for MultiUseSandbox::restore - #1728

Merged
ludfjig merged 4 commits into
mainfrom
ll/snapshot-restore-layout-compatibility
Aug 25, 2026
Merged

ludfjig merged 4 commits into
mainfrom
ll/snapshot-restore-layout-compatibility

Conversation

@ludfjig

@ludfjig ludfjig commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

This makes it possible to restore snapshots from different guest binaries and memory layouts into a sandbox, provided the registered host functions are compatible.

closes #1592

@ludfjig ludfjig changed the title snapshot restore layout compatibility Relax layout requirements for MultiUseSandbox::restore Aug 12, 2026
@ludfjig ludfjig added the kind/enhancement For PRs adding features, improving functionality, docs, tests, etc. label Aug 12, 2026
@ludfjig
ludfjig force-pushed the ll/snapshot-restore-layout-compatibility branch from 2074b7b to 2150200 Compare August 12, 2026 18:11
@ludfjig
ludfjig force-pushed the ll/snapshot-restore-layout-compatibility branch 2 times, most recently from afdbb20 to d4e7519 Compare August 12, 2026 23:08
@ludfjig
ludfjig force-pushed the ll/snapshot-restore-layout-compatibility branch from d4e7519 to f0fa0c2 Compare August 13, 2026 19:46
@ludfjig
ludfjig force-pushed the ll/snapshot-restore-layout-compatibility branch 2 times, most recently from 3518a13 to a110461 Compare August 13, 2026 21:38
@ludfjig
ludfjig force-pushed the ll/snapshot-restore-layout-compatibility branch from a110461 to 8297af8 Compare August 13, 2026 22:44
@ludfjig
ludfjig marked this pull request as ready for review August 13, 2026 23:20
@ludfjig
ludfjig requested a review from danbugs as a code owner August 13, 2026 23:20
Copilot AI lite review requested due to automatic review settings August 13, 2026 23:20
@ludfjig
ludfjig force-pushed the ll/snapshot-restore-layout-compatibility branch from 5edde4f to 2c77eff Compare August 18, 2026 01:20
@ludfjig
ludfjig force-pushed the ll/snapshot-restore-layout-compatibility branch 2 times, most recently from 1313477 to d0c4cf0 Compare August 18, 2026 17:45
@ludfjig
ludfjig force-pushed the ll/snapshot-restore-layout-compatibility branch from d0c4cf0 to 900796a Compare August 18, 2026 18:40
@ludfjig
ludfjig force-pushed the ll/snapshot-restore-layout-compatibility branch from 900796a to 715d187 Compare August 18, 2026 21:13
jprendes
jprendes previously approved these changes Aug 19, 2026

@jprendes jprendes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ludfjig
ludfjig dismissed jprendes’s stale review August 19, 2026 19:22

The merge-base changed after approval.

@ludfjig
ludfjig force-pushed the ll/snapshot-restore-layout-compatibility branch from 715d187 to 09d6fda Compare August 19, 2026 19:22
jprendes
jprendes previously approved these changes Aug 19, 2026
Base automatically changed from ll/snapshot-restore-transaction to main August 19, 2026 21:34
@ludfjig
ludfjig force-pushed the ll/snapshot-restore-layout-compatibility branch from 09d6fda to e618cc9 Compare August 19, 2026 21:34
Comment thread src/hyperlight_host/src/sandbox/initialized_multi_use.rs
Comment thread src/hyperlight_host/src/sandbox/initialized_multi_use.rs Outdated
@ludfjig
ludfjig force-pushed the ll/snapshot-restore-layout-compatibility branch from 5e74093 to a537f79 Compare August 24, 2026 18:12
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
@ludfjig
ludfjig force-pushed the ll/snapshot-restore-layout-compatibility branch from a537f79 to 3b05e44 Compare August 24, 2026 20:49
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
@ludfjig
ludfjig force-pushed the ll/snapshot-restore-layout-compatibility branch from 3b05e44 to 0147dfb Compare August 24, 2026 21:04

@syntactically syntactically left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not look at the new tests in any detail, but apart from that this looks good!

Comment thread src/hyperlight_host/src/sandbox/initialized_multi_use.rs
@ludfjig
ludfjig merged commit 637bbc4 into main Aug 25, 2026
53 checks passed
@ludfjig
ludfjig deleted the ll/snapshot-restore-layout-compatibility branch August 25, 2026 22:19
@github-actions github-actions Bot removed the ready-for-review PR is ready for (re-)review label Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement For PRs adding features, improving functionality, docs, tests, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reconsider SandboxMemoryLayout::is_compatible_with on snapshot restore

4 participants