fix(http1): fix reading large bodies on 32-bit systems#4056
Merged
seanmonstar merged 1 commit intomasterfrom Apr 27, 2026
Merged
fix(http1): fix reading large bodies on 32-bit systems#4056seanmonstar merged 1 commit intomasterfrom
seanmonstar merged 1 commit intomasterfrom
Conversation
Although it is not important, I believe it is guaranteed to happen if ever remaining becomes larger than usize::MAX. The code can never decrease remaining more than to_read, thus it cannot pass below the usize::MAX boundary... |
aa70258 to
d20bfcb
Compare
Member
Author
|
You're right, I stepped through a bit more. I've adjusted the language and title. |
On 32-bit systems, the cast of the length to read from a u64 to a usize could truncate, and cause less to be read. If the length was larger than usize::MAX, the end could not be read. To fix this, we use a saturating cast pattern instead. Closes #4055
d20bfcb to
e8f6e6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On 32-bit systems, the cast of the length to read from a u64 to a usize could
truncate, and cause less to be read. If the length was larger than usize::MAX,
the end could not be read.
To fix this, we use a saturating cast pattern instead.
Closes #4055