Skip to content

fix a few tests#7564

Closed
yiyixuxu wants to merge 12 commits into
mainfrom
fix-tests
Closed

fix a few tests#7564
yiyixuxu wants to merge 12 commits into
mainfrom
fix-tests

Conversation

@yiyixuxu
Copy link
Copy Markdown
Collaborator

@yiyixuxu yiyixuxu commented Apr 2, 2024

No description provided.

):
super().__init__()

if hasattr(scheduler.config, "steps_offset") and scheduler.config.steps_offset != 1:
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this pipeline use the SD checkpoints so do the same deprecation as SD pipeline
this is the reason the from_pipe test failed here https://github.com/huggingface/diffusers/actions/runs/8514833413/job/23321268337#step:9:73

i.e. when we do pipe.from_pretrained(), the deprecated scheduler config (clip_sample, step_offset) is not updated; but when we do pipe = ...from_pipe(pipe_sd), these config got updated when creating pipe_sd

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 3, 2024

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions Bot added the stale Issues that haven't received updates label May 3, 2024
@yiyixuxu yiyixuxu removed the stale Issues that haven't received updates label May 3, 2024
Comment thread tests/pipelines/kandinsky2_2/test_kandinsky_img2img.py Outdated
@sayakpaul
Copy link
Copy Markdown
Member

@yiyixuxu wanted to know the state of this PR. Do you need a review?

@yiyixuxu
Copy link
Copy Markdown
Collaborator Author

yiyixuxu commented Jun 3, 2024

oh yes @sayakpaul

@yiyixuxu yiyixuxu requested review from DN6 and sayakpaul June 3, 2024 18:19
Comment on lines +144 to +170
0.55489814,
0.57733,
0.5055906,
0.45875436,
0.47063118,
0.5364321,
0.40426704,
0.44867495,
0.44591445,
0.5281508,
0.6315466,
0.62435544,
0.54455715,
0.477045,
0.5789583,
0.58372897,
0.41623285,
0.60586095,
0.65277576,
0.41136372,
0.6803191,
0.5731553,
0.3580435,
0.5695902,
0.42043707,
0.3784843,
0.53030723,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these getting changed?

max_diff_without_adapter_scale,
expected_max_diff,
"Output without ip-adapter must be same as normal inference",
f"Output without ip-adapter must be same as normal inference, exppected {output_without_adapter}, got {output_without_adapter_scale}",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"expected"

@github-actions
Copy link
Copy Markdown
Contributor

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions Bot added the stale Issues that haven't received updates label Sep 14, 2024
@yiyixuxu yiyixuxu closed this Aug 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale Issues that haven't received updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants