Use native memory efficient attention in PyTorch 2.0 if possible#2778
Closed
haotian-liu wants to merge 1 commit into
Closed
Use native memory efficient attention in PyTorch 2.0 if possible#2778haotian-liu wants to merge 1 commit into
haotian-liu wants to merge 1 commit into
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
Contributor
|
@haotian-liu this class is to be deprecated and in fact, the PR to remove it is #2697 The |
Contributor
|
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
Contributor
|
Hey @haotian-liu , I think this has been fixed with: #3200 |
Author
|
Great, thank you! Closing this as fixed in #3200. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When users use PyTorch 2.0, and do not explicit enable memory efficient attention with xformers, this can potentially lead to OOM issues (while the user may believe that the efficient attention is automatically enabled with PyTorch 2.0).