Preserve HookRegistry forward signatures - #14143
Open
momomuchu wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
HookRegistry.register_hookwrappedmodule.forwardwith a generic callable. After hook registration,inspect.signature(module.forward)reported:instead of the original model
forwardsignature.This broke
torch.exportkeyword binding because kwargs such ashidden_statesandtimestepwere bound against the wrapper signature.Root cause
The replacement
forwardusedfunctools.partialplusfunctools.update_wrapper, but it did not carry the original boundforwardsignature onto the installed wrapper.Fix
Capture
inspect.signature(forward)before wrapping, then assign it toself._module_ref.forward.__signature__after installing the wrapped partial.This keeps introspection aligned with the model API while leaving hook execution unchanged.
Tests
inspect.signature(model.forward).torch.export.exportstill accepts keyword inputs after hook registration.inspect.signature(model.forward)still equals the original, andtorch.export.exportstill binds keyword inputs. This covers the case where a secondregister_hookcould otherwise capture the wrapper signature instead of the model signature.Fixes #14135.