Skip to content

Guard against calling optional ftfy module if not available#13409

Open
awsr wants to merge 5 commits intohuggingface:mainfrom
awsr:patch-1
Open

Guard against calling optional ftfy module if not available#13409
awsr wants to merge 5 commits intohuggingface:mainfrom
awsr:patch-1

Conversation

@awsr
Copy link
Copy Markdown

@awsr awsr commented Apr 4, 2026

What does this PR do?

Fixes NameError: name 'ftfy' is not defined

This was encountered by one of our users on SDNext. I'm not entirely sure why ftfy didn't get installed, but if it's optionally imported then it should also be optionally called.

Before submitting

Not applicable:

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Was this discussed/approved via a GitHub issue or the forum? Please add a link to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Tagging: @sayakpaul @yiyixuxu @DN6

@awsr awsr changed the title Add missing ftfy availability check for WAN I2V pipeline Guard against calling optional ftfy module if not available Apr 4, 2026
@awsr
Copy link
Copy Markdown
Author

awsr commented Apr 4, 2026

I added all the missing ftfy checks that would cause exceptions. I had originally added explicit checks to other uses, but I reverted those because they're not related to this particular issue and aren't actual errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant