Fix MPS compatibility in get_1d_sincos_pos_embed_from_grid #12432#12449
Merged
DN6 merged 5 commits intohuggingface:mainfrom Oct 23, 2025
Merged
Fix MPS compatibility in get_1d_sincos_pos_embed_from_grid #12432#12449DN6 merged 5 commits intohuggingface:mainfrom
DN6 merged 5 commits intohuggingface:mainfrom
Conversation
Collaborator
|
@bot /style |
Contributor
|
Style fix is beginning .... View the workflow run here. |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
Author
Contributor
|
it looks good, it mirrors how i was going to approach it. i have health issues this week and might take time to return a response, but i am following along. thank you for your contribution. |
Contributor
Author
|
@bghira Thank you for review quickly last week, kindly review as it Look good to you ,Workflows awaiting approval. |
Collaborator
|
@bot /style |
Contributor
|
Style bot fixed some files and pushed the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix MPS compatibility in get_1d_sincos_pos_embed_from_grid
Add dtype parameter with auto-detection for MPS devices. MPS doesn't support
float64, so the function now automatically uses float32 on MPS while maintaining
float64 on CUDA/CPU for backward compatibility. Users can also explicitly
override the dtype if needed.
Fixes #12432
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Co-authored-by: @malakazlan
Who can review?
@bghira
@DN6