Repository navigation
Configure eMudhra interception on an extra HTTPS port - #267
Open
igolaizola wants to merge 1 commit into
Open
igolaizola wants to merge 1 commit into
igolaizola wants to merge 1 commit into
Conversation
Use the legacy AAA cross-sign for opt-in interception without changing the local CA or installing certificates in clients. Refs httptoolkit/httptoolkit#934
There was a problem hiding this comment.
🟡 Changes recommended
The lockfile pins Mockttp 4.6.5, which lacks the required extra-HTTPS APIs, preventing the new listener from being enabled and causing integration tests to fail on clean installs.
1 open issue
What changed in this PR
This PR configures opt-in eMudhra interception through an additional HTTPS port while preserving HTTP Toolkit’s existing local CA and normal interception.
Changes:
- Adds eMudhra key material and the legacy AAA cross-signed certificate.
- Registers eMudhra as an extra HTTPS option for proxy sessions.
- Adds integration tests for certificate trust, shared session behavior, session isolation, and port cleanup.
| File | Description |
|---|---|
test/integration/emudhra.spec.ts |
Tests opt-in interception and additional-port lifecycle. |
test/fixtures/aaa-certificate-services.pem |
Supplies the AAA root certificate for test trust validation. |
src/index.ts |
Configures the eMudhra extra HTTPS option. |
src/emudhra.ts |
Contains the eMudhra key and legacy cross-signed certificate. |
Review effort: Balanced
Comment on lines
+204
to
+205
| extraHttps: { | ||
| emudhra: { key: EMUDHRA_KEY, cert: EMUDHRA_CERT } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the legacy AAA cross-sign for opt-in interception without changing the local CA or installing certificates in clients.
Refs httptoolkit/httptoolkit#934