HTTP 5.0 no longer supports VCR

[hugopassos]

As a result of #546, requests made with VCR are now raising the error KeyError: key not found: :request as the parameter request is not sent by it:

The error will be raised at /lib/http/response.rb:46

Can't it behave like an optional parameter like it was in the previous version of the gem?

[tarcieri]

It seems like for the purposes of VCR, which is trying to simulate how real-world requests behave, it should probably start passing :request for http.rb v5. Otherwise it will be missing for VCR-simulated requests, which seems like you'd get different behavior depending on whether or not you're using VCR.

We could potentially allow :request to be omitted as a workaround, but that seems suboptimal for the specific use case of VCR, IMO.

[hugopassos]

I get your point. So maybe I should open an issue in there? Sorry I am no specialist in this matter and my first thought was to do it in here as in previous HTTP.rb versions it worked fine, and it is also working fine in other libraries

[tarcieri]

IIRC VCR uses webmock (haven't used it in awhile, sorry) so that would probably be the right place to enquire about this. There might already be a relevant issue.

[cesc1989]

👋🏽 @hugopassos this was fixed in bblimke/webmock#940

Update webmock to 3.13.0

[tarcieri]

Awesome, thanks!

[hugopassos]

@cesc1989 thanks!