Handle no WifiManager and prevent crash#3555
Merged
JBassett merged 3 commits intohome-assistant:masterfrom May 28, 2023
Merged
Conversation
jpelgrom
changed the title
WiFiManager and prevent crashWifiManager and prevent crash
JBassett
approved these changes
May 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix #3536 by gracefully handling no
WifiManagerand hiding related options and features.Unable to test this as all my devices and emulators have Wi-Fi, but manually changing things to false seems to work as expected.
Screenshots
Link to pull request in Documentation repository
No Wi-Fi is clearly an exception, I don't think this is worth mentioning in the docs
Any other notes