finished mssql data dictionary support#1402
Merged
hhyo merged 3 commits intohhyo:masterfrom Mar 2, 2022
quanbisen:feature/data_dictionary_mssql_support
Merged
finished mssql data dictionary support#1402hhyo merged 3 commits intohhyo:masterfrom quanbisen:feature/data_dictionary_mssql_support
hhyo merged 3 commits intohhyo:masterfrom
quanbisen:feature/data_dictionary_mssql_support
Conversation
Collaborator
Author
|
为啥CI没跑成功？我应该没改其它东西呀。 |
Owner
|
https://github.com/hhyo/Archery/runs/5334022985?check_suite_focus=true#step:8:1070 FAIL: test_table_list (sql.tests.TestDataDictionary) |
Codecov Report
@@ Coverage Diff @@
## master #1402 +/- ##
==========================================
- Coverage 75.25% 74.86% -0.40%
==========================================
Files 82 82
Lines 12938 12998 +60
==========================================
- Hits 9737 9731 -6
- Misses 3201 3267 +66
Continue to review full report at Codecov.
|
Collaborator
Author
|
修改了测试用例的返回，可以了。bug我还修复了上次合并支持Oracle类型的页面（当打开MySQL的表信息时，remove了Oracle的表信息页面，当打开Oracle页面时，也把MySQL页面remove了）打开无元素的问题。 |
xxlaila
pushed a commit
to xxlaila/Archery
that referenced
this pull request
Feb 15, 2025
* finished mssql data dictionary support * fixed test case not pass * 更新功能清单support表格 Co-authored-by: quanbisen <quanbisen@banggood.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
遵循软件设计开放闭合原则，把数据字典页面的接口抽离出来，放到EngineBase里，在原有数据字典支持MySQL和Oracle，新增支持MsSQL类型。