Repository navigation
Conversation
Preview approval requiredThis pull request comes from a fork, so Mintlify won't build a preview until someone with write access approves commit |
pqminh27
force-pushed
the
fix/distributed-cli-integer-flags
branch
2 times, most recently
from
November 1, 2026 09:25
940fbdf to
e4bdfa3
Compare
pqminh27
marked this pull request as ready for review
November 1, 2026 09:31
pqminh27
force-pushed
the
fix/distributed-cli-integer-flags
branch
3 times, most recently
from
November 2, 2026 17:07
8aa018b to
59d1f4c
Compare
pqminh27
force-pushed
the
fix/distributed-cli-integer-flags
branch
from
November 3, 2026 03:18
59d1f4c to
eedbd68
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Require complete base-10 integer tokens for non-empty integer flags in Lambda and Cloud Run. Empty optional values remain equivalent to omitted flags, and required dimensions retain their existing missing-value errors.
Why
Number.parseIntsilently changed values such as1920.5,24.5, and1920pxinto different valid numbers, so a render could use dimensions or an FPS the caller did not request.Related work
Fixes #6889.
How
Validate the whole token before conversion, then apply the existing positivity and supported-FPS checks. Validate deploy and batch tuning options before adapter, state, or Terraform work. Update the CLI documentation and add regression coverage.
Test plan
bun run --cwd packages/cli test -- src/commands/lambda.test.ts src/commands/cloudrun.test.ts src/cli.agentMode.test.ts— 558 passedbun run --cwd packages/cli typecheck— passedoxlinton the five changed TypeScript files — passedoxfmt --checkon the changed files — passedbun run testinpackages/cli— 7,155 passed, 11 failed, 195 skipped; failures were in seven files unchanged by this PR (cloud/offload.undecodableTrack,commands/history,server/fileWatcher.atomic,server/fileWatcher.fs,server/studioServer.stampOnOpen,whisper/sherpa, andutils/artifactCapture)Manual check with the latest published CLI v0.8.223; malformed values passed argument parsing and the command stopped at the missing optional adapter, before a render was dispatched
Unit tests added/updated
Manual testing performed
Documentation updated (if applicable)
Comments follow CONTRIBUTING.md "Comments": they say why, not what, and a bug fix says what the code must do and how to reproduce the bug
Rebase validation
Rebase validation — 2026-11-03 (
eedbd682156c): Rebased onto upstreammainat5e30bbdbe14bwithout conflicts; the original 1-commit series and stable patch IDs were preserved. Full monorepo build passed; focused CLI tests: 566 passed across 3 suites; CLI typecheck, changed TypeScript lint, changed-file formatting and git diff --check passed. Live AWS/GCP deployment was not exercised; GitHub CI authorization remains a maintainer action.