Skip to content

fix(cli): reject partial integer flags - #6890

Open
pqminh27 wants to merge 1 commit into
heygen-com:mainfrom
pqminh27:fix/distributed-cli-integer-flags
Open

pqminh27 wants to merge 1 commit into
heygen-com:mainfrom
pqminh27:fix/distributed-cli-integer-flags

Conversation

@pqminh27

@pqminh27 pqminh27 commented Oct 31, 2026 •

Copy link
Copy Markdown

What

Require complete base-10 integer tokens for non-empty integer flags in Lambda and Cloud Run. Empty optional values remain equivalent to omitted flags, and required dimensions retain their existing missing-value errors.

Why

Number.parseInt silently changed values such as 1920.5, 24.5, and 1920px into different valid numbers, so a render could use dimensions or an FPS the caller did not request.

Related work

Fixes #6889.

How

Validate the whole token before conversion, then apply the existing positivity and supported-FPS checks. Validate deploy and batch tuning options before adapter, state, or Terraform work. Update the CLI documentation and add regression coverage.

Test plan

  • bun run --cwd packages/cli test -- src/commands/lambda.test.ts src/commands/cloudrun.test.ts src/cli.agentMode.test.ts — 558 passed

  • bun run --cwd packages/cli typecheck — passed

  • oxlint on the five changed TypeScript files — passed

  • oxfmt --check on the changed files — passed

  • bun run test in packages/cli — 7,155 passed, 11 failed, 195 skipped; failures were in seven files unchanged by this PR (cloud/offload.undecodableTrack, commands/history, server/fileWatcher.atomic, server/fileWatcher.fs, server/studioServer.stampOnOpen, whisper/sherpa, and utils/artifactCapture)

  • Manual check with the latest published CLI v0.8.223; malformed values passed argument parsing and the command stopped at the missing optional adapter, before a render was dispatched

  • Unit tests added/updated

  • Manual testing performed

  • Documentation updated (if applicable)

  • Comments follow CONTRIBUTING.md "Comments": they say why, not what, and a bug fix says what the code must do and how to reproduce the bug

Rebase validation

Rebase validation — 2026-11-03 (eedbd682156c): Rebased onto upstream main at 5e30bbdbe14b without conflicts; the original 1-commit series and stable patch IDs were preserved. Full monorepo build passed; focused CLI tests: 566 passed across 3 suites; CLI typecheck, changed TypeScript lint, changed-file formatting and git diff --check passed. Live AWS/GCP deployment was not exercised; GitHub CI authorization remains a maintainer action.

@mintlify

mintlify Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Preview approval required

This pull request comes from a fork, so Mintlify won't build a preview until someone with write access approves commit eedbd68.

Approve preview

@pqminh27
pqminh27 force-pushed the fix/distributed-cli-integer-flags branch 2 times, most recently from 940fbdf to e4bdfa3 Compare November 1, 2026 09:25
@pqminh27
pqminh27 marked this pull request as ready for review November 1, 2026 09:31
@pqminh27
pqminh27 force-pushed the fix/distributed-cli-integer-flags branch 3 times, most recently from 8aa018b to 59d1f4c Compare November 2, 2026 17:07
@pqminh27
pqminh27 force-pushed the fix/distributed-cli-integer-flags branch from 59d1f4c to eedbd68 Compare November 3, 2026 03:18

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CLI] Reject non-integer tokens for distributed render flags

1 participant