Repository navigation
perf(lint): strip stylesheet comments once per canvas zoom scan - #5712
Merged
miguel-heygen merged 1 commit intoOct 16, 2026
Merged
Conversation
miguel-heygen
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long stylesheets are repeatedly scanned in full while checking canvas-level zoom: the rule loop calls
stripCssComments(style.content)for each matched CSS rule and once more when the loop ends. Strip once per stylesheet and reuse the same string for the unchanged regex loop.Fixes #5681.
Validation:
diagnoseDerivedEnd.Validation limitations: this characterization captures inputs to the downstream classifier rather than running the complete linter. The prescribed workspace build was attempted and failed because
tsupis unavailable. Full linter suite, project-level CLI reproduction and workspace typecheck have not passed locally.AI-assisted implementation and validation.