Repository navigation
fix(producer): make sparse keyframe advice conditional - #5343
Open
user-github-me wants to merge 1 commit into
Open
user-github-me wants to merge 1 commit into
user-github-me wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make the sparse-keyframe warning explain that long GOPs can slow preview seeking, with re-encoding advice conditional on observed slow seeking.
Why
The warning currently states that sparse keyframes cause seek failures and frame freezing, even when FFmpeg extracts the requested frames correctly. A real 10-second, single-keyframe clip extracted at eight seconds produces all 30 requested frames, with the first frame matching independent FFmpeg frame-240 output pixel for pixel.
Related work
Refs #3460, specifically the maintainer's diagnostic wording follow-up. #3998 already covers single-keyframe classification using video-stream duration. #3573 and #3762 were closed while the warning's scope remained open. No open PR currently covers this diagnostic.
How
Update the compiler warning and its threshold comment to describe an advisory seeking cost. Keep the existing interval calculation and re-encoding command. Add compiler integration tests using FFmpeg-generated media for the conditional warning and for a one-second video with a ten-second audio track, which should remain below the warning threshold.
Test plan