Repository navigation
fix(skills): check local render dependencies before design - #5339
Open
user-github-me wants to merge 4 commits into
Open
user-github-me wants to merge 4 commits into
user-github-me wants to merge 4 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check FFmpeg and FFprobe after project setup or resume, before local video design begins. The entry skill, CLI loop, and motion-graphics workflow use the existing
doctor --jsoncheck and inspect both tools individually, so missing optional voice or Docker tools do not block local encoding.On macOS, the install hint now covers existing executable paths and project-local binaries alongside Homebrew. Fresh
BRIEF.mdcreation stays first afterinit; a valid dependency result is retained during the run. Decks, source ports, and explicit cloud rendering use their own prerequisites.Fixes #5232. Completes the early workflow check after #5237's binary-setup documentation. The main integration preserves newer CLI-skill guidance and regenerates the manifest from the combined skill sources.
Validation: all 66 FFmpeg, preflight, and doctor tests pass. Seven isolated cases through the built CLI verify configured and project-local binaries, PATH and explicit-path precedence, and each/both missing overrides. Working setups pass the documented two-tool jq gate despite optional-tool failures; missing setups and two incomplete-report controls fail it. Packaged core skill pages match the source. Full workspace build, CLI typecheck, repository lint, formatting, skill/reference and manifest validation, mirror and test reachability checks, comment checks, and normal commit hooks pass. Every published update has a GitHub-verified signature, and the final repository tree exactly matches the tested local merge.