Repository navigation
fix(producer): distinguish project files in cache hashes - #5249
Closed
user-github-me wants to merge 1 commit into
Closed
user-github-me wants to merge 1 commit into
user-github-me wants to merge 1 commit into
Conversation
Collaborator
|
Thanks for this. The encoding is technically ambiguous, but a collision needs a file that ends in a NUL byte followed by exactly the next file's path and contents. That doesn't happen with real project trees, and the cache sits in the user's own bucket. Since the change also invalidates every existing project ID on upgrade, we'd rather not take it right now. — Rames |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Project cache keys currently concatenate each file path and its bytes without delimiting the end of the contents. A tree containing
a = "bc\0def"hashes identically to a tree containing emptyaplusbc = "def". Both cloud adapters then skip uploading the changed tree and reuse the wrong project.Include the byte length before each file's contents in the shared hash input. Keep deterministic traversal, the 16-character ID format, and the existing top-level skip rules. Cover the collision in the hash helper and both adapters.
Validation:
main; unchanged-tree, binary/Unicode, empty-file, rename, and skip-rule controls pass.Default project IDs change on upgrade, causing one fresh upload per project. Existing handles and explicit
siteIdoverrides continue to work. No live cloud deployment was used.\n