Repository navigation
fix(sdk): preserve unquoted escapes in inline styles - #5246
Open
user-github-me wants to merge 1 commit into
Open
user-github-me wants to merge 1 commit into
user-github-me wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An inline CSS custom property such as
--label: alpha\;betais valid, but changing an unrelatedcolorthrough the SDK splits at its escaped semicolon and rewrites the value. Escaped quotes and parentheses can make the scanner swallow later declarations, leaving undo unable to restore color.Handle an escaped character before checking quote state in the existing inline-style scanner. This keeps escaped punctuation inside an unquoted value while an escaped backslash followed by an ordinary semicolon still ends the declaration.
Validation:
typecheck:examplesreports existing examples/test typing errors; its output is byte-identical on unchanged main.